Skip to content

Commit

Permalink
staging:iio: Remove noop call to __iio_update_buffer
Browse files Browse the repository at this point in the history
__iio_update_buffer updates the buffer's bytes_per_datum and length fields.
But the only user of this function just passes in these exact fields, so the
call basically looks like this:

	buffer->bytes_per_datum = buffer->bytes_per_datum;
	buffer->length = buffer->length;

Which means it is a noop and can be removed. Also remove the function itself,
since it is now unused.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
  • Loading branch information
Lars-Peter Clausen authored and Jonathan Cameron committed Jan 31, 2013
1 parent 872e79a commit 999517f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 14 deletions.
1 change: 0 additions & 1 deletion drivers/iio/kfifo_buf.c
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ static inline int __iio_allocate_kfifo(struct iio_kfifo *buf,
if ((length == 0) || (bytes_per_datum == 0))
return -EINVAL;

__iio_update_buffer(&buf->buffer, bytes_per_datum, length);
return __kfifo_alloc((struct __kfifo *)&buf->kf, length,
bytes_per_datum, GFP_KERNEL);
}
Expand Down
13 changes: 0 additions & 13 deletions include/linux/iio/buffer.h
Original file line number Diff line number Diff line change
Expand Up @@ -103,19 +103,6 @@ int iio_update_buffers(struct iio_dev *indio_dev,
**/
void iio_buffer_init(struct iio_buffer *buffer);

/**
* __iio_update_buffer() - update common elements of buffers
* @buffer: buffer that is the event source
* @bytes_per_datum: size of individual datum including timestamp
* @length: number of datums in buffer
**/
static inline void __iio_update_buffer(struct iio_buffer *buffer,
int bytes_per_datum, int length)
{
buffer->bytes_per_datum = bytes_per_datum;
buffer->length = length;
}

int iio_scan_mask_query(struct iio_dev *indio_dev,
struct iio_buffer *buffer, int bit);

Expand Down

0 comments on commit 999517f

Please sign in to comment.