Skip to content

Commit

Permalink
mac80211: cancel restart_work explicitly instead of depending on flus…
Browse files Browse the repository at this point in the history
…h_scheduled_work()

iee80211_hw->restart_work is the only work which uses the system
workqueue.  Instead of calling flush_scheduled_work() during
iee80211_exit(), cancel the work during unregistration.

This is to prepare for the deprecation and removal of
flush_scheduled_work().

Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Tejun Heo authored and John W. Linville committed Oct 25, 2010
1 parent 229aebb commit 99b88a0
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions net/mac80211/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -748,7 +748,7 @@ int ieee80211_register_hw(struct ieee80211_hw *hw)
hw->queues = IEEE80211_MAX_QUEUES;

local->workqueue =
create_singlethread_workqueue(wiphy_name(local->hw.wiphy));
alloc_ordered_workqueue(wiphy_name(local->hw.wiphy), 0);
if (!local->workqueue) {
result = -ENOMEM;
goto fail_workqueue;
Expand Down Expand Up @@ -962,12 +962,6 @@ static void __exit ieee80211_exit(void)
rc80211_minstrel_ht_exit();
rc80211_minstrel_exit();

/*
* For key todo, it'll be empty by now but the work
* might still be scheduled.
*/
flush_scheduled_work();

if (mesh_allocated)
ieee80211s_stop();

Expand Down

0 comments on commit 99b88a0

Please sign in to comment.