Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 75633
b: refs/heads/master
c: 4960c9d
h: refs/heads/master
i:
  75631: ad44541
v: v3
  • Loading branch information
Thomas Gleixner committed Jan 22, 2008
1 parent 0099fc9 commit 99d5e4d
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 29 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: b2214fca2bf7db492cd508769da7ca703a7f1806
refs/heads/master: 4960c9df1407c2723459c60ff13e6efe0c209c62
12 changes: 2 additions & 10 deletions trunk/arch/x86/kernel/io_apic_32.c
Original file line number Diff line number Diff line change
Expand Up @@ -2169,14 +2169,10 @@ static inline void __init check_timer(void)
{
int apic1, pin1, apic2, pin2;
int vector;
unsigned int ver;
unsigned long flags;

local_irq_save(flags);

ver = apic_read(APIC_LVR);
ver = GET_APIC_VERSION(ver);

/*
* get/set the timer IRQ vector:
*/
Expand All @@ -2189,15 +2185,11 @@ static inline void __init check_timer(void)
* mode for the 8259A whenever interrupts are routed
* through I/O APICs. Also IRQ0 has to be enabled in
* the 8259A which implies the virtual wire has to be
* disabled in the local APIC. Finally timer interrupts
* need to be acknowledged manually in the 8259A for
* timer_interrupt() and for the i82489DX when using
* the NMI watchdog.
* disabled in the local APIC.
*/
apic_write_around(APIC_LVT0, APIC_LVT_MASKED | APIC_DM_EXTINT);
init_8259A(1);
timer_ack = !cpu_has_tsc;
timer_ack |= (nmi_watchdog == NMI_IO_APIC && !APIC_INTEGRATED(ver));
timer_ack = 1;
if (timer_over_8254 > 0)
enable_8259A_irq(0);

Expand Down
9 changes: 2 additions & 7 deletions trunk/arch/x86/kernel/nmi_32.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@

#include <asm/smp.h>
#include <asm/nmi.h>
#include <asm/timer.h>

#include "mach_traps.h"

Expand Down Expand Up @@ -84,7 +83,7 @@ static int __init check_nmi_watchdog(void)

prev_nmi_count = kmalloc(NR_CPUS * sizeof(int), GFP_KERNEL);
if (!prev_nmi_count)
goto error;
return -1;

printk(KERN_INFO "Testing NMI watchdog ... ");

Expand Down Expand Up @@ -119,7 +118,7 @@ static int __init check_nmi_watchdog(void)
if (!atomic_read(&nmi_active)) {
kfree(prev_nmi_count);
atomic_set(&nmi_active, -1);
goto error;
return -1;
}
printk("OK.\n");

Expand All @@ -130,10 +129,6 @@ static int __init check_nmi_watchdog(void)

kfree(prev_nmi_count);
return 0;
error:
timer_ack = !cpu_has_tsc;

return -1;
}
/* This needs to happen later in boot so counters are working */
late_initcall(check_nmi_watchdog);
Expand Down
4 changes: 2 additions & 2 deletions trunk/drivers/w1/slaves/w1_therm.c
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ static struct w1_therm_family_converter w1_therm_families[] = {

static inline int w1_DS18B20_convert_temp(u8 rom[9])
{
s16 t = (rom[1] << 8) | rom[0];
int t = (rom[1] << 8) | rom[0];
t /= 16;
return t;
}
Expand Down Expand Up @@ -204,7 +204,7 @@ static ssize_t w1_therm_read_bin(struct kobject *kobj,

crc = w1_calc_crc8(rom, 8);

if (rom[8] == crc)
if (rom[8] == crc && rom[0])
verdict = 1;
}
}
Expand Down
2 changes: 1 addition & 1 deletion trunk/kernel/rcupdate.c
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,7 @@ static void rcu_init_percpu_data(int cpu, struct rcu_ctrlblk *rcp,
rdp->blimit = blimit;
}

static void __cpuinit rcu_online_cpu(int cpu)
static void __devinit rcu_online_cpu(int cpu)
{
struct rcu_data *rdp = &per_cpu(rcu_data, cpu);
struct rcu_data *bh_rdp = &per_cpu(rcu_bh_data, cpu);
Expand Down
8 changes: 0 additions & 8 deletions trunk/kernel/sched.c
Original file line number Diff line number Diff line change
Expand Up @@ -7153,14 +7153,6 @@ int sched_group_set_shares(struct task_group *tg, unsigned long shares)
{
int i;

/*
* A weight of 0 or 1 can cause arithmetics problems.
* (The default weight is 1024 - so there's no practical
* limitation from this.)
*/
if (shares < 2)
shares = 2;

spin_lock(&tg->lock);
if (tg->shares == shares)
goto done;
Expand Down

0 comments on commit 99d5e4d

Please sign in to comment.