Skip to content

Commit

Permalink
Input: wm97xx - add possibility to control the GPIO_STATUS shift
Browse files Browse the repository at this point in the history
This patch allows tweaking the behaviour of GPIO_STATUS register
shift quirk that's in wm97xx-core. The problem with GPIO_STATUS
register being shifted by one doesn't appear on all hardware it
seems and causes problems with accelerated touchscreen drivers on
Palm hardware. Therefore an accelerated touchscreen driver can select
if the shift is/isn't happening on the hardware.

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
  • Loading branch information
Marek Vasut authored and Dmitry Torokhov committed Jul 21, 2009
1 parent b833306 commit 99fde51
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 2 deletions.
3 changes: 3 additions & 0 deletions drivers/input/touchscreen/mainstone-wm97xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,9 @@ static int wm97xx_acc_startup(struct wm97xx *wm)
if (machine_is_palmt5() || machine_is_palmtx() || machine_is_palmld()) {
pen_int = 1;
irq = 27;
/* There is some obscure mutant of WM9712 interbred with WM9713
* used on Palm HW */
wm->variant = WM97xx_WM1613;
} else if (machine_is_mainstone() && pen_int)
irq = 4;

Expand Down
6 changes: 4 additions & 2 deletions drivers/input/touchscreen/wm97xx-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ void wm97xx_set_gpio(struct wm97xx *wm, u32 gpio,
else
reg &= ~gpio;

if (wm->id == WM9712_ID2)
if (wm->id == WM9712_ID2 && wm->variant != WM97xx_WM1613)
wm97xx_reg_write(wm, AC97_GPIO_STATUS, reg << 1);
else
wm97xx_reg_write(wm, AC97_GPIO_STATUS, reg);
Expand Down Expand Up @@ -307,7 +307,7 @@ static void wm97xx_pen_irq_worker(struct work_struct *work)
WM97XX_GPIO_13);
}

if (wm->id == WM9712_ID2)
if (wm->id == WM9712_ID2 && wm->variant != WM97xx_WM1613)
wm97xx_reg_write(wm, AC97_GPIO_STATUS, (status &
~WM97XX_GPIO_13) << 1);
else
Expand Down Expand Up @@ -582,6 +582,8 @@ static int wm97xx_probe(struct device *dev)

wm->id = wm97xx_reg_read(wm, AC97_VENDOR_ID2);

wm->variant = WM97xx_GENERIC;

dev_info(wm->dev, "detected a wm97%02x codec\n", wm->id & 0xff);

switch (wm->id & 0xff) {
Expand Down
7 changes: 7 additions & 0 deletions include/linux/wm97xx.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@
#include <linux/input.h> /* Input device layer */
#include <linux/platform_device.h>

/*
* WM97xx variants
*/
#define WM97xx_GENERIC 0x0000
#define WM97xx_WM1613 0x1613

/*
* WM97xx AC97 Touchscreen registers
*/
Expand Down Expand Up @@ -283,6 +289,7 @@ struct wm97xx {
unsigned pen_is_down:1; /* Pen is down */
unsigned aux_waiting:1; /* aux measurement waiting */
unsigned pen_probably_down:1; /* used in polling mode */
u16 variant; /* WM97xx chip variant */
u16 suspend_mode; /* PRP in suspend mode */
};

Expand Down

0 comments on commit 99fde51

Please sign in to comment.