Skip to content

Commit

Permalink
pinctrl: split pincontrol states into its own header
Browse files Browse the repository at this point in the history
Move the pin control state defines into its own header file,
since it is used both by machine.h which is facing the platform
and by consumer.h which is facing the drivers, and pinctrl.h
which is pinctrl-driver internal, let's not have each and every
.h file include all others, then isolation is moot.

Acked-by: Stephen Warren <swarren@wwwdotorg.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
  • Loading branch information
Linus Walleij committed Mar 6, 2012
1 parent 872acc3 commit 9a01be1
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 4 deletions.
2 changes: 1 addition & 1 deletion include/linux/pinctrl/consumer.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#include <linux/err.h>
#include <linux/list.h>
#include <linux/seq_file.h>
#include "pinctrl.h"
#include "pinctrl-state.h"

/* This struct is private to the core and should be regarded as a cookie */
struct pinctrl;
Expand Down
2 changes: 1 addition & 1 deletion include/linux/pinctrl/machine.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
#ifndef __LINUX_PINCTRL_MACHINE_H
#define __LINUX_PINCTRL_MACHINE_H

#include "pinctrl.h"
#include "pinctrl-state.h"

enum pinctrl_map_type {
PIN_MAP_TYPE_INVALID,
Expand Down
6 changes: 6 additions & 0 deletions include/linux/pinctrl/pinctrl-state.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
/*
* Standard pin control state definitions
*/

#define PINCTRL_STATE_DEFAULT "default"
#define PINCTRL_STATE_IDLE "idle"
3 changes: 1 addition & 2 deletions include/linux/pinctrl/pinctrl.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@
#include <linux/radix-tree.h>
#include <linux/list.h>
#include <linux/seq_file.h>

#define PINCTRL_STATE_DEFAULT "default"
#include "pinctrl-state.h"

struct pinctrl_dev;
struct pinmux_ops;
Expand Down

0 comments on commit 9a01be1

Please sign in to comment.