Skip to content

Commit

Permalink
KVM: MMU: using __xchg_spte more smarter
Browse files Browse the repository at this point in the history
Sometimes, atomically set spte is not needed, this patch call __xchg_spte()
more smartly

Note: if the old mapping's access bit is already set, we no need atomic operation
since the access bit is not lost

Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
  • Loading branch information
Xiao Guangrong authored and Avi Kivity committed Aug 2, 2010
1 parent e4b502e commit 9a3aad7
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions arch/x86/kvm/mmu.c
Original file line number Diff line number Diff line change
Expand Up @@ -682,9 +682,14 @@ static void rmap_remove(struct kvm *kvm, u64 *spte)
static void set_spte_track_bits(u64 *sptep, u64 new_spte)
{
pfn_t pfn;
u64 old_spte;
u64 old_spte = *sptep;

if (!shadow_accessed_mask || !is_shadow_present_pte(old_spte) ||
old_spte & shadow_accessed_mask) {
__set_spte(sptep, new_spte);
} else
old_spte = __xchg_spte(sptep, new_spte);

old_spte = __xchg_spte(sptep, new_spte);
if (!is_rmap_spte(old_spte))
return;
pfn = spte_to_pfn(old_spte);
Expand Down

0 comments on commit 9a3aad7

Please sign in to comment.