Skip to content

Commit

Permalink
[PATCH] reiserfs: make resize option auto-get new device size
Browse files Browse the repository at this point in the history
It's trivial for the resize option to auto-get the underlying device size,
while it's harder for the user.  I've copied the code from jfs.

Since of the different reiserfs option parser (which does not use the
superior match_token used by almost every other filesystem), I've had to
use the "resize=auto" and not "resize" option to specify this behaviour.
Changing the option parser to the kernel one wouldn't be bad but I've no
time to do this cleanup in this moment.

Btw, the mount(8) man page should be updated to include this option.  Cc
the relevant people, please (I hope I cc'ed the right people).

Cc: <reiserfs-dev@namesys.com>
Cc: <reiserfs-list@namesys.com>
Cc: <mtk-manpages@gmx.net>
Cc: Alex Zarochentsev <zam@namesys.com>
Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Paolo 'Blaisorblade' Giarrusso authored and Linus Torvalds committed May 1, 2005
1 parent a83f1fe commit 9a3bb30
Showing 1 changed file with 14 additions and 7 deletions.
21 changes: 14 additions & 7 deletions fs/reiserfs/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -889,12 +889,18 @@ static int reiserfs_parse_options (struct super_block * s, char * options, /* st
char * p;

p = NULL;
/* "resize=NNN" */
*blocks = simple_strtoul (arg, &p, 0);
if (*p != '\0') {
/* NNN does not look like a number */
reiserfs_warning (s, "reiserfs_parse_options: bad value %s", arg);
return 0;
/* "resize=NNN" or "resize=auto" */

if (!strcmp(arg, "auto")) {
/* From JFS code, to auto-get the size.*/
*blocks = s->s_bdev->bd_inode->i_size >> s->s_blocksize_bits;
} else {
*blocks = simple_strtoul (arg, &p, 0);
if (*p != '\0') {
/* NNN does not look like a number */
reiserfs_warning (s, "reiserfs_parse_options: bad value %s", arg);
return 0;
}
}
}

Expand All @@ -903,7 +909,8 @@ static int reiserfs_parse_options (struct super_block * s, char * options, /* st
unsigned long val = simple_strtoul (arg, &p, 0);
/* commit=NNN (time in seconds) */
if ( *p != '\0' || val >= (unsigned int)-1) {
reiserfs_warning (s, "reiserfs_parse_options: bad value %s", arg); return 0;
reiserfs_warning (s, "reiserfs_parse_options: bad value %s", arg);
return 0;
}
*commit_max_age = (unsigned int)val;
}
Expand Down

0 comments on commit 9a3bb30

Please sign in to comment.