Skip to content

Commit

Permalink
wusb: return -ENOTCONN when resetting a port with no connected device
Browse files Browse the repository at this point in the history
If reading the device descriptor fails during hub_port_init() fails,
then the port is disabled, disconnecting the device.  The port is then
reset at the start of the next init attempt but there is no device to
reset.

Signed-off-by: David Vrabel <david.vrabel@csr.com>
  • Loading branch information
David Vrabel committed Jan 6, 2009
1 parent 2226b1c commit 9a9b1d1
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions drivers/usb/wusbcore/devconnect.c
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,7 @@ static void __wusbhc_dev_disconnect(struct wusbhc *wusbhc,
| USB_PORT_STAT_LOW_SPEED | USB_PORT_STAT_HIGH_SPEED);
port->change |= USB_PORT_STAT_C_CONNECTION | USB_PORT_STAT_C_ENABLE;
if (wusb_dev) {
dev_dbg(wusbhc->dev, "disconnecting device from port %d\n", wusb_dev->port_idx);
if (!list_empty(&wusb_dev->cack_node))
list_del_init(&wusb_dev->cack_node);
/* For the one in cack_add() */
Expand Down
3 changes: 3 additions & 0 deletions drivers/usb/wusbcore/rh.c
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,9 @@ static int wusbhc_rh_port_reset(struct wusbhc *wusbhc, u8 port_idx)
struct wusb_port *port = wusb_port_by_idx(wusbhc, port_idx);
struct wusb_dev *wusb_dev = port->wusb_dev;

if (wusb_dev == NULL)
return -ENOTCONN;

port->status |= USB_PORT_STAT_RESET;
port->change |= USB_PORT_STAT_C_RESET;

Expand Down

0 comments on commit 9a9b1d1

Please sign in to comment.