Skip to content

Commit

Permalink
x86: don't use word-size specifiers.
Browse files Browse the repository at this point in the history
Since the instructions refer to registers, they'll be able
to figure it out.

Signed-off-by: Glauber Costa <gcosta@redhat.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Glauber Costa authored and Ingo Molnar committed Jul 9, 2008
1 parent edf1016 commit 9aa0388
Showing 1 changed file with 12 additions and 12 deletions.
24 changes: 12 additions & 12 deletions arch/x86/lib/getuser_32.S
Original file line number Diff line number Diff line change
Expand Up @@ -29,44 +29,44 @@
ENTRY(__get_user_1)
CFI_STARTPROC
GET_THREAD_INFO(%edx)
cmpl TI_addr_limit(%edx),%eax
cmp TI_addr_limit(%edx),%eax
jae bad_get_user
1: movzbl (%eax),%edx
xorl %eax,%eax
1: movzb (%eax),%edx
xor %eax,%eax
ret
CFI_ENDPROC
ENDPROC(__get_user_1)

ENTRY(__get_user_2)
CFI_STARTPROC
addl $1,%eax
add $1,%eax
jc bad_get_user
GET_THREAD_INFO(%edx)
cmpl TI_addr_limit(%edx),%eax
cmp TI_addr_limit(%edx),%eax
jae bad_get_user
2: movzwl -1(%eax),%edx
xorl %eax,%eax
xor %eax,%eax
ret
CFI_ENDPROC
ENDPROC(__get_user_2)

ENTRY(__get_user_4)
CFI_STARTPROC
addl $3,%eax
add $3,%eax
jc bad_get_user
GET_THREAD_INFO(%edx)
cmpl TI_addr_limit(%edx),%eax
cmp TI_addr_limit(%edx),%eax
jae bad_get_user
3: movl -3(%eax),%edx
xorl %eax,%eax
3: mov -3(%eax),%edx
xor %eax,%eax
ret
CFI_ENDPROC
ENDPROC(__get_user_4)

bad_get_user:
CFI_STARTPROC
xorl %edx,%edx
movl $-14,%eax
xor %edx,%edx
mov $-14,%eax
ret
CFI_ENDPROC
END(bad_get_user)
Expand Down

0 comments on commit 9aa0388

Please sign in to comment.