Skip to content

Commit

Permalink
pcmcia/pcnet_cs: fix 'shadow variable' warning
Browse files Browse the repository at this point in the history
Fixing:
  CHECK   drivers/net/pcmcia/pcnet_cs.c
drivers/net/pcmcia/pcnet_cs.c:523:15: warning: symbol 'hw_info' shadows an earlier one
drivers/net/pcmcia/pcnet_cs.c:148:18: originally declared here

Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se>
Acked-by: Alan Cox <alan@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Richard Knutsson authored and Linus Torvalds committed Feb 5, 2008
1 parent cfd4734 commit 9ab9898
Showing 1 changed file with 13 additions and 13 deletions.
26 changes: 13 additions & 13 deletions drivers/net/pcmcia/pcnet_cs.c
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,7 @@ static int pcnet_config(struct pcmcia_device *link)
int i, last_ret, last_fn, start_pg, stop_pg, cm_offset;
int has_shmem = 0;
u_short buf[64];
hw_info_t *hw_info;
hw_info_t *local_hw_info;
DECLARE_MAC_BUF(mac);

DEBUG(0, "pcnet_config(0x%p)\n", link);
Expand Down Expand Up @@ -590,23 +590,23 @@ static int pcnet_config(struct pcmcia_device *link)
dev->if_port = 0;
}

hw_info = get_hwinfo(link);
if (hw_info == NULL)
hw_info = get_prom(link);
if (hw_info == NULL)
hw_info = get_dl10019(link);
if (hw_info == NULL)
hw_info = get_ax88190(link);
if (hw_info == NULL)
hw_info = get_hwired(link);

if (hw_info == NULL) {
local_hw_info = get_hwinfo(link);
if (local_hw_info == NULL)
local_hw_info = get_prom(link);
if (local_hw_info == NULL)
local_hw_info = get_dl10019(link);
if (local_hw_info == NULL)
local_hw_info = get_ax88190(link);
if (local_hw_info == NULL)
local_hw_info = get_hwired(link);

if (local_hw_info == NULL) {
printk(KERN_NOTICE "pcnet_cs: unable to read hardware net"
" address for io base %#3lx\n", dev->base_addr);
goto failed;
}

info->flags = hw_info->flags;
info->flags = local_hw_info->flags;
/* Check for user overrides */
info->flags |= (delay_output) ? DELAY_OUTPUT : 0;
if ((link->manf_id == MANFID_SOCKET) &&
Expand Down

0 comments on commit 9ab9898

Please sign in to comment.