Skip to content

Commit

Permalink
dma: mv_xor: remove hw_id field from platform_data
Browse files Browse the repository at this point in the history
There is no need for the platform_data to give this ID, it is simply
the channel number, so we can compute it inside the driver when
registering the channels.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
  • Loading branch information
Thomas Petazzoni committed Nov 20, 2012
1 parent c819ce1 commit 9aedbdb
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 8 deletions.
4 changes: 0 additions & 4 deletions arch/arm/plat-orion/common.c
Original file line number Diff line number Diff line change
Expand Up @@ -627,11 +627,9 @@ static struct resource orion_xor0_shared_resources[] = {

static struct mv_xor_channel_data orion_xor0_channels_data[2] = {
{
.hw_id = 0,
.pool_size = PAGE_SIZE,
},
{
.hw_id = 1,
.pool_size = PAGE_SIZE,
},
};
Expand Down Expand Up @@ -702,11 +700,9 @@ static struct resource orion_xor1_shared_resources[] = {

static struct mv_xor_channel_data orion_xor1_channels_data[2] = {
{
.hw_id = 0,
.pool_size = PAGE_SIZE,
},
{
.hw_id = 1,
.pool_size = PAGE_SIZE,
},
};
Expand Down
6 changes: 3 additions & 3 deletions drivers/dma/mv_xor.c
Original file line number Diff line number Diff line change
Expand Up @@ -1088,7 +1088,7 @@ static int mv_xor_channel_remove(struct mv_xor_chan *mv_chan)
static struct mv_xor_chan *
mv_xor_channel_add(struct mv_xor_device *xordev,
struct platform_device *pdev,
int hw_id, dma_cap_mask_t cap_mask,
int idx, dma_cap_mask_t cap_mask,
size_t pool_size, int irq)
{
int ret = 0;
Expand All @@ -1101,7 +1101,7 @@ mv_xor_channel_add(struct mv_xor_device *xordev,
goto err_free_dma;
}

mv_chan->idx = hw_id;
mv_chan->idx = idx;

dma_dev = &mv_chan->dmadev;

Expand Down Expand Up @@ -1295,7 +1295,7 @@ static int mv_xor_probe(struct platform_device *pdev)
}

xordev->channels[i] =
mv_xor_channel_add(xordev, pdev, cd->hw_id,
mv_xor_channel_add(xordev, pdev, i,
cd->cap_mask,
cd->pool_size, irq);
if (IS_ERR(xordev->channels[i])) {
Expand Down
1 change: 0 additions & 1 deletion include/linux/platform_data/dma-mv_xor.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
#define MV_XOR_NAME "mv_xor"

struct mv_xor_channel_data {
int hw_id;
dma_cap_mask_t cap_mask;
size_t pool_size;
};
Expand Down

0 comments on commit 9aedbdb

Please sign in to comment.