Skip to content

Commit

Permalink
V4L/DVB (8754): uvcvideo: Implement the USB power management reset_re…
Browse files Browse the repository at this point in the history
…sume method.

When a suspended device has been reset instead of being resumed, USB core
calls the reset_resume method if available instead of unbinding and rebinding
the device.

This patch implements reset_resume by reusing the current resume
implementation and simplifies the resume method by skipping the controls
restore stage. Resuming from autosuspend should be faster.

Signed-off-by: Laurent Pinchart <laurent.pinchart@skynet.be>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Laurent Pinchart authored and Mauro Carvalho Chehab committed Oct 12, 2008
1 parent 14d9626 commit 9b0ae86
Showing 1 changed file with 13 additions and 2 deletions.
15 changes: 13 additions & 2 deletions drivers/media/video/uvc/uvc_driver.c
Original file line number Diff line number Diff line change
Expand Up @@ -1663,7 +1663,7 @@ static int uvc_suspend(struct usb_interface *intf, pm_message_t message)
return uvc_video_suspend(&dev->video);
}

static int uvc_resume(struct usb_interface *intf)
static int __uvc_resume(struct usb_interface *intf, int reset)
{
struct uvc_device *dev = usb_get_intfdata(intf);
int ret;
Expand All @@ -1672,7 +1672,7 @@ static int uvc_resume(struct usb_interface *intf)
intf->cur_altsetting->desc.bInterfaceNumber);

if (intf->cur_altsetting->desc.bInterfaceSubClass == SC_VIDEOCONTROL) {
if ((ret = uvc_ctrl_resume_device(dev)) < 0)
if (reset && (ret = uvc_ctrl_resume_device(dev)) < 0)
return ret;

return uvc_status_resume(dev);
Expand All @@ -1687,6 +1687,16 @@ static int uvc_resume(struct usb_interface *intf)
return uvc_video_resume(&dev->video);
}

static int uvc_resume(struct usb_interface *intf)
{
return __uvc_resume(intf, 0);
}

static int uvc_reset_resume(struct usb_interface *intf)
{
return __uvc_resume(intf, 1);
}

/* ------------------------------------------------------------------------
* Driver initialization and cleanup
*/
Expand Down Expand Up @@ -1952,6 +1962,7 @@ struct uvc_driver uvc_driver = {
.disconnect = uvc_disconnect,
.suspend = uvc_suspend,
.resume = uvc_resume,
.reset_resume = uvc_reset_resume,
.id_table = uvc_ids,
.supports_autosuspend = 1,
},
Expand Down

0 comments on commit 9b0ae86

Please sign in to comment.