Skip to content

Commit

Permalink
ktest: Ignore errors it tests if IGNORE_ERRORS is set
Browse files Browse the repository at this point in the history
The option IGNORE_ERRORS is used to allow a test to succeed even if a
warning appears from the kernel. Sometimes kernels will produce warnings
that are not associated with a test, and the user wants to test
something else.

The IGNORE_ERRORS works for boot up, but was not preventing test runs to
succeed if the kernel produced a warning.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
  • Loading branch information
Steven Rostedt authored and Steven Rostedt committed Jul 30, 2012
1 parent c1434dc commit 9b1d367
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion tools/testing/ktest/ktest.pl
Original file line number Diff line number Diff line change
Expand Up @@ -2074,6 +2074,7 @@ sub do_run_test {
my $line;
my $full_line;
my $bug = 0;
my $bug_ignored = 0;

wait_for_monitor 1;

Expand All @@ -2098,7 +2099,11 @@ sub do_run_test {
doprint $line;

if ($full_line =~ /call trace:/i) {
$bug = 1;
if ($ignore_errors) {
$bug_ignored = 1;
} else {
$bug = 1;
}
}

if ($full_line =~ /Kernel panic -/) {
Expand All @@ -2111,6 +2116,10 @@ sub do_run_test {
}
} while (!$child_done && !$bug);

if (!$bug && $bug_ignored) {
doprint "WARNING: Call Trace detected but ignored due to IGNORE_ERRORS=1\n";
}

if ($bug) {
my $failure_start = time;
my $now;
Expand Down

0 comments on commit 9b1d367

Please sign in to comment.