Skip to content

Commit

Permalink
[media] stk1160: warrant a NUL terminated string
Browse files Browse the repository at this point in the history
strncpy() doesn't warrant a NUL terminated string. Use
strlcpy() instead.

Fixes Coverity bug CID#1195195.

Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
  • Loading branch information
Mauro Carvalho Chehab committed Apr 8, 2014
1 parent bbe24c6 commit 9b2c06a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/media/usb/stk1160/stk1160-ac97.c
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ int stk1160_ac97_register(struct stk1160 *dev)
"stk1160-mixer");
snprintf(card->longname, sizeof(card->longname),
"stk1160 ac97 codec mixer control");
strncpy(card->driver, dev->dev->driver->name, sizeof(card->driver));
strlcpy(card->driver, dev->dev->driver->name, sizeof(card->driver));

rc = snd_ac97_bus(card, 0, &stk1160_ac97_ops, NULL, &ac97_bus);
if (rc)
Expand Down

0 comments on commit 9b2c06a

Please sign in to comment.