Skip to content

Commit

Permalink
powerpc/irq: Move get_irq() comment into header
Browse files Browse the repository at this point in the history
The guts of do_IRQ() isn't really the right place to be documenting
the ppc_md.get_irq() interface. So move the comment into machdep.h

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
  • Loading branch information
Michael Ellerman authored and Benjamin Herrenschmidt committed May 21, 2009
1 parent d7cb10d commit 9b647a3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
4 changes: 4 additions & 0 deletions arch/powerpc/include/asm/machdep.h
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,10 @@ struct machdep_calls {
void (*show_percpuinfo)(struct seq_file *m, int i);

void (*init_IRQ)(void);

/* Return an irq, or NO_IRQ to indicate there are none pending.
* If for some reason there is no irq, but the interrupt
* shouldn't be counted as spurious, return NO_IRQ_IGNORE. */
unsigned int (*get_irq)(void);
#ifdef CONFIG_KEXEC
void (*kexec_cpu_down)(int crash_shutdown, int secondary);
Expand Down
7 changes: 0 additions & 7 deletions arch/powerpc/kernel/irq.c
Original file line number Diff line number Diff line change
Expand Up @@ -326,13 +326,6 @@ void do_IRQ(struct pt_regs *regs)

check_stack_overflow();

/*
* Every platform is required to implement ppc_md.get_irq.
* This function will either return an irq number or NO_IRQ to
* indicate there are no more pending.
* The value NO_IRQ_IGNORE is for buggy hardware and means that this
* IRQ has already been handled. -- Tom
*/
irq = ppc_md.get_irq();

if (irq != NO_IRQ && irq != NO_IRQ_IGNORE)
Expand Down

0 comments on commit 9b647a3

Please sign in to comment.