Skip to content

Commit

Permalink
IB/mthca: Remove unnecessary read of PCI_CAP_ID_EXP
Browse files Browse the repository at this point in the history
The PCIE capability offset is saved during PCI bus walking.  It will
remove an unnecessary search in the PCI configuration space if this
value is referenced instead of reacquiring it.  Also, pci_is_pcie is a
better way of determining if the device is PCIE or not (as it uses the
same saved PCIE capability offset).

Signed-off-by: Jon Mason <jdmason@kudzu.us>
Signed-off-by: Roland Dreier <roland@purestorage.com>
  • Loading branch information
Jon Mason authored and Roland Dreier committed Jul 18, 2011
1 parent cdb73db commit 9b89925
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion drivers/infiniband/hw/mthca/mthca_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ static int mthca_tune_pci(struct mthca_dev *mdev)
} else if (!(mdev->mthca_flags & MTHCA_FLAG_PCIE))
mthca_info(mdev, "No PCI-X capability, not setting RBC.\n");

if (pci_find_capability(mdev->pdev, PCI_CAP_ID_EXP)) {
if (pci_is_pcie(mdev->pdev)) {
if (pcie_set_readrq(mdev->pdev, 4096)) {
mthca_err(mdev, "Couldn't write PCI Express read request, "
"aborting.\n");
Expand Down
2 changes: 1 addition & 1 deletion drivers/infiniband/hw/mthca/mthca_reset.c
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ int mthca_reset(struct mthca_dev *mdev)
}

hca_pcix_cap = pci_find_capability(mdev->pdev, PCI_CAP_ID_PCIX);
hca_pcie_cap = pci_find_capability(mdev->pdev, PCI_CAP_ID_EXP);
hca_pcie_cap = pci_pcie_cap(mdev->pdev);

if (bridge) {
bridge_header = kmalloc(256, GFP_KERNEL);
Expand Down

0 comments on commit 9b89925

Please sign in to comment.