Skip to content

Commit

Permalink
greth: greth_set_mac_add would corrupt the MAC address.
Browse files Browse the repository at this point in the history
The MAC address was set using the signed char sockaddr->sa_addr
field and thus the address could be corrupted through sign extension.

Signed-off-by: Kristoffer Glembo <kristoffer@gaisler.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Kristoffer Glembo authored and David S. Miller committed Jul 5, 2011
1 parent c349a52 commit 9b9cfe7
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions drivers/net/greth.c
Original file line number Diff line number Diff line change
Expand Up @@ -1015,11 +1015,10 @@ static int greth_set_mac_add(struct net_device *dev, void *p)
return -EINVAL;

memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);
GRETH_REGSAVE(regs->esa_msb, dev->dev_addr[0] << 8 | dev->dev_addr[1]);
GRETH_REGSAVE(regs->esa_lsb, dev->dev_addr[2] << 24 | dev->dev_addr[3] << 16 |
dev->dev_addr[4] << 8 | dev->dev_addr[5]);

GRETH_REGSAVE(regs->esa_msb, addr->sa_data[0] << 8 | addr->sa_data[1]);
GRETH_REGSAVE(regs->esa_lsb,
addr->sa_data[2] << 24 | addr->
sa_data[3] << 16 | addr->sa_data[4] << 8 | addr->sa_data[5]);
return 0;
}

Expand Down

0 comments on commit 9b9cfe7

Please sign in to comment.