Skip to content

Commit

Permalink
[IA64] SKI Simulator boot
Browse files Browse the repository at this point in the history
Sorry I didn't notice earlier, but that BUG_ON triggers for me on the
simulator.  AFAICS the mask for itv is set in cpu_init(), which comes
after sal_init().  Consequently on the simulator the itv still has its
start value of zero.  I've probably missed something, but I wonder why
at this stage of the boot you even need to save and restore the itv?

Signed-Off-By: Ian Wienand <ianw@gelato.unsw.edu.au>
Signed-off-by: Tony Luck <tony.luck@intel.com>
  • Loading branch information
Ian Wienand authored and Tony Luck committed Jun 21, 2006
1 parent f640f94 commit 9ba8933
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions arch/ia64/kernel/sal.c
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ static int sal_cache_flush_drops_interrupts;
static void __init
check_sal_cache_flush (void)
{
unsigned long flags, itv;
unsigned long flags;
int cpu;
u64 vector;

Expand All @@ -238,9 +238,6 @@ check_sal_cache_flush (void)
* Schedule a timer interrupt, wait until it's reported, and see if
* SAL_CACHE_FLUSH drops it.
*/
itv = ia64_get_itv();
BUG_ON((itv & (1 << 16)) == 0);

ia64_set_itv(IA64_TIMER_VECTOR);
ia64_set_itm(ia64_get_itc() + 1000);

Expand All @@ -260,7 +257,6 @@ check_sal_cache_flush (void)
ia64_eoi();
}

ia64_set_itv(itv);
local_irq_restore(flags);
put_cpu();
}
Expand Down

0 comments on commit 9ba8933

Please sign in to comment.