Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 46321
b: refs/heads/master
c: a34fbc6
h: refs/heads/master
i:
  46319: 3952ec1
v: v3
  • Loading branch information
Patrick Caulfield authored and Steven Whitehouse committed Feb 5, 2007
1 parent 6a23cd3 commit 9be06ec
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 7 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 62a0f62369b0fece37f6652d69b918c89d53c3b3
refs/heads/master: a34fbc6363256387372331000462691bc4b3f5a9
15 changes: 9 additions & 6 deletions trunk/fs/dlm/lowcomms-tcp.c
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
*******************************************************************************
**
** Copyright (C) Sistina Software, Inc. 1997-2003 All rights reserved.
** Copyright (C) 2004-2006 Red Hat, Inc. All rights reserved.
** Copyright (C) 2004-2007 Red Hat, Inc. All rights reserved.
**
** This copyrighted material is made available to anyone wishing to use,
** modify, copy, or redistribute it subject to the terms and conditions
Expand Down Expand Up @@ -109,7 +109,6 @@ struct connection {
struct page *rx_page;
struct cbuf cb;
int retries;
atomic_t waiting_requests;
#define MAX_CONNECT_RETRIES 3
struct connection *othercon;
struct work_struct rwork; /* Receive workqueue */
Expand Down Expand Up @@ -278,8 +277,11 @@ static int receive_from_sock(struct connection *con)

mutex_lock(&con->sock_mutex);

if (con->sock == NULL)
goto out;
if (con->sock == NULL) {
ret = -EAGAIN;
goto out_close;
}

if (con->rx_page == NULL) {
/*
* This doesn't need to be atomic, but I think it should
Expand Down Expand Up @@ -352,7 +354,6 @@ static int receive_from_sock(struct connection *con)
con->rx_page = NULL;
}

out:
if (call_again_soon)
goto out_resched;
mutex_unlock(&con->sock_mutex);
Expand All @@ -370,6 +371,9 @@ static int receive_from_sock(struct connection *con)
close_connection(con, false);
/* Reconnect when there is something to send */
}
/* Don't return success if we really got EOF */
if (ret == 0)
ret = -EAGAIN;

return ret;
}
Expand Down Expand Up @@ -847,7 +851,6 @@ int dlm_lowcomms_close(int nodeid)
if (con) {
clean_one_writequeue(con);
close_connection(con, true);
atomic_set(&con->waiting_requests, 0);
}
return 0;

Expand Down

0 comments on commit 9be06ec

Please sign in to comment.