Skip to content

Commit

Permalink
ktest: Use different temp config name for minconfig
Browse files Browse the repository at this point in the history
By using the "use_config" for minconfig and addconfig we risk
trying to copy itself to itself, which will cause an unexpected failure.

Use a different name instead.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
  • Loading branch information
Steven Rostedt authored and Steven Rostedt committed Nov 18, 2010
1 parent d1fbd7e commit 9be2e6b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tools/testing/ktest/ktest.pl
Original file line number Diff line number Diff line change
Expand Up @@ -1735,9 +1735,9 @@ sub set_test_option {
$minconfig = $addconfig;

} elsif (defined($addconfig)) {
run_command "cat $addconfig $minconfig > $tmpdir/use_config" or
run_command "cat $addconfig $minconfig > $tmpdir/add_config" or
dodie "Failed to create temp config";
$minconfig = "$tmpdir/use_config";
$minconfig = "$tmpdir/add_config";
}

my $checkout = $opt{"CHECKOUT[$i]"};
Expand Down

0 comments on commit 9be2e6b

Please sign in to comment.