Skip to content

Commit

Permalink
sparc32: probe for cpu info only during startup
Browse files Browse the repository at this point in the history
We did a cpu_probe() call each time a CPU got online - which
only effect was to save latest CPU/FPU info for use by show_cpuinfo().
Use same setup as for sparc64 where we probe for this info during startup,
and only once.

This allowed us to annotate a few functions __init which again
fixed the following section mismatch warnings:

WARNING: vmlinux.o(.text+0x65f0): Section mismatch in reference from the function set_cpu_and_fpu() to the (unknown reference) .init.rodata:(unknown)
WARNING: vmlinux.o(.text+0x65f8): Section mismatch in reference from the function set_cpu_and_fpu() to the (unknown reference) .init.rodata:(unknown)
WARNING: vmlinux.o(.text+0x664c): Section mismatch in reference from the function set_cpu_and_fpu() to the variable .init.rodata:manufacturer_info
WARNING: vmlinux.o(.text+0x6650): Section mismatch in reference from the function set_cpu_and_fpu() to the variable .init.rodata:manufacturer_info

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Sam Ravnborg authored and David S. Miller committed Apr 21, 2011
1 parent cb1b820 commit 9c2853a
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 13 deletions.
1 change: 0 additions & 1 deletion arch/sparc/include/asm/leon.h
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,6 @@ extern void leon_smp_done(void);
extern void leon_boot_cpus(void);
extern int leon_boot_one_cpu(int i);
void leon_init_smp(void);
extern void cpu_probe(void);
extern void cpu_idle(void);
extern void init_IRQ(void);
extern void cpu_panic(void);
Expand Down
12 changes: 8 additions & 4 deletions arch/sparc/kernel/cpu.c
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ static const char *sparc_fpu_type;
const char *sparc_pmu_type;


static void set_cpu_and_fpu(int psr_impl, int psr_vers, int fpu_vers)
static void __init set_cpu_and_fpu(int psr_impl, int psr_vers, int fpu_vers)
{
const struct manufacturer_info *manuf;
int i;
Expand Down Expand Up @@ -434,7 +434,7 @@ const struct seq_operations cpuinfo_op = {
};

#ifdef CONFIG_SPARC32
void __cpuinit cpu_probe(void)
static int __init cpu_type_probe(void)
{
int psr_impl, psr_vers, fpu_vers;
int psr;
Expand All @@ -453,8 +453,12 @@ void __cpuinit cpu_probe(void)
put_psr(psr);

set_cpu_and_fpu(psr_impl, psr_vers, fpu_vers);

return 0;
}
#else
#endif /* CONFIG_SPARC32 */

#ifdef CONFIG_SPARC64
static void __init sun4v_cpu_probe(void)
{
switch (sun4v_chip_type) {
Expand Down Expand Up @@ -495,6 +499,6 @@ static int __init cpu_type_probe(void)
}
return 0;
}
#endif /* CONFIG_SPARC64 */

early_initcall(cpu_type_probe);
#endif
2 changes: 0 additions & 2 deletions arch/sparc/kernel/devices.c
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
#include <asm/system.h>
#include <asm/cpudata.h>

extern void cpu_probe(void);
extern void clock_stop_probe(void); /* tadpole.c */
extern void sun4c_probe_memerr_reg(void);

Expand Down Expand Up @@ -133,7 +132,6 @@ void __init device_scan(void)
}
#endif /* !CONFIG_SMP */

cpu_probe();
{
extern void auxio_probe(void);
extern void auxio_power_probe(void);
Expand Down
2 changes: 0 additions & 2 deletions arch/sparc/kernel/leon_smp.c
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,6 @@ void __cpuinit leon_callin(void)
local_flush_cache_all();
local_flush_tlb_all();

cpu_probe();

/* Fix idle thread fields. */
__asm__ __volatile__("ld [%0], %%g6\n\t" : : "r"(&current_set[cpuid])
: "memory" /* paranoid */);
Expand Down
2 changes: 0 additions & 2 deletions arch/sparc/kernel/sun4d_smp.c
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,6 @@ void __cpuinit smp4d_callin(void)
local_flush_cache_all();
local_flush_tlb_all();

cpu_probe();

while ((unsigned long)current_set[cpuid] < PAGE_OFFSET)
barrier();

Expand Down
2 changes: 0 additions & 2 deletions arch/sparc/kernel/sun4m_smp.c
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,6 @@ void __cpuinit smp4m_callin(void)
local_flush_cache_all();
local_flush_tlb_all();

cpu_probe();

/* Fix idle thread fields. */
__asm__ __volatile__("ld [%0], %%g6\n\t"
: : "r" (&current_set[cpuid])
Expand Down

0 comments on commit 9c2853a

Please sign in to comment.