Skip to content

Commit

Permalink
isa-skelton: Remove a wrong netif_wake_queue() call
Browse files Browse the repository at this point in the history
The netif_wake_queue() is called correctly (i.e. only on !txfull
condition) from net_tx().  So Unconditional call to the
netif_wake_queue() here is wrong.  This might cause calling of
start_xmit routine on txfull state and trigger tx-ring overflow.

This fix is ported from commit 662a96b
("tc35815: Remove a wrong netif_wake_queue() call which triggers BUG_ON").

Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Atsushi Nemoto authored and David S. Miller committed Feb 26, 2010
1 parent fbc450b commit 9c5f9c2
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/net/isa-skeleton.c
Original file line number Diff line number Diff line change
Expand Up @@ -536,7 +536,6 @@ static irqreturn_t net_interrupt(int irq, void *dev_id)
/* Transmit complete. */
net_tx(dev);
np->stats.tx_packets++;
netif_wake_queue(dev);
}
#endif
if (status & COUNTERS_INTR) {
Expand Down

0 comments on commit 9c5f9c2

Please sign in to comment.