Skip to content

Commit

Permalink
NFSD: Use unsigned length argument for decode_pathname
Browse files Browse the repository at this point in the history
Clean up: path name lengths are unsigned on the wire, negative lengths
are not meaningful natively either.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Acked-By: NeilBrown <neilb@suse.de>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
  • Loading branch information
Chuck Lever authored and J. Bruce Fields committed Feb 1, 2008
1 parent 5a022fc commit 9c7544d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions fs/nfsd/nfsxdr.c
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,10 @@ decode_filename(__be32 *p, char **namp, unsigned int *lenp)
}

static __be32 *
decode_pathname(__be32 *p, char **namp, int *lenp)
decode_pathname(__be32 *p, char **namp, unsigned int *lenp)
{
char *name;
int i;
unsigned int i;

if ((p = xdr_decode_string_inplace(p, namp, lenp, NFS_MAXPATHLEN)) != NULL) {
for (i = 0, name = *namp; i < *lenp; i++, name++) {
Expand Down

0 comments on commit 9c7544d

Please sign in to comment.