Skip to content

Commit

Permalink
ath5k: avoid and warn on potential infinite loop
Browse files Browse the repository at this point in the history
If we are trying to interpolate a curve with slope == 0, the return
value will always be the y-coordinate.  In this code we are looping
until we reach a minimum y-coordinate on a line, which in the 0-slope
case can never happen, thus the loop never terminates.

The PCDAC steps come from the EEPROM and should never be equal, but
we should gracefully handle that case, so warn and bail out.

Reported-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Bob Copeland <me@bobcopeland.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Bob Copeland authored and John W. Linville committed May 20, 2009
1 parent 61405e9 commit 9c8b3ed
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/net/wireless/ath/ath5k/phy.c
Original file line number Diff line number Diff line change
Expand Up @@ -1897,6 +1897,9 @@ ath5k_get_linear_pcdac_min(const u8 *stepL, const u8 *stepR,
s16 min_pwrL, min_pwrR;
s16 pwr_i;

if (WARN_ON(stepL[0] == stepL[1] || stepR[0] == stepR[1]))
return 0;

if (pwrL[0] == pwrL[1])
min_pwrL = pwrL[0];
else {
Expand Down

0 comments on commit 9c8b3ed

Please sign in to comment.