Skip to content

Commit

Permalink
[media] via-camera: disable RGB mode
Browse files Browse the repository at this point in the history
The RGB mode does not work correctly. It captures fine at 640x480
but whenever the scaling engine is used to produce another resolution,
color corruption occurs (lots of erroneous pink and green).

It is not clear how the scaling engine is supposed to work and how
it knows which pixel format it is dealing with. Work around this
problem by disabling RGB support. YUYV scaling works just fine.

Test case:

	gst-launch v4l2src ! video/x-raw-rgb,bpp=16,width=320,height=240 ! \
	ffmpegcolorspace ! xvimagesink

Signed-off-by: Daniel Drake <dsd@laptop.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Daniel Drake authored and Mauro Carvalho Chehab committed Nov 7, 2011
1 parent 318cde3 commit 9c900f0
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions drivers/media/video/via-camera.c
Original file line number Diff line number Diff line change
Expand Up @@ -156,14 +156,10 @@ static struct via_format {
.mbus_code = V4L2_MBUS_FMT_YUYV8_2X8,
.bpp = 2,
},
{
.desc = "RGB 565",
.pixelformat = V4L2_PIX_FMT_RGB565,
.mbus_code = V4L2_MBUS_FMT_RGB565_2X8_LE,
.bpp = 2,
},
/* RGB444 and Bayer should be doable, but have never been
tested with this driver. */
tested with this driver. RGB565 seems to work at the default
resolution, but results in color corruption when being scaled by
viacam_set_scaled(), and is disabled as a result. */
};
#define N_VIA_FMTS ARRAY_SIZE(via_formats)

Expand Down

0 comments on commit 9c900f0

Please sign in to comment.