Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 208332
b: refs/heads/master
c: 6f904ff
h: refs/heads/master
v: v3
  • Loading branch information
Artem Bityutskiy authored and Jens Axboe committed Aug 7, 2010
1 parent 57461c8 commit 9cab51e
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 16 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 4aeefdc69f7b6f3f287e6fd8d4b213953b9e92d8
refs/heads/master: 6f904ff0e39ea88f81eb77e8dfb4e1238492f0a8
2 changes: 1 addition & 1 deletion trunk/fs/fs-writeback.c
Original file line number Diff line number Diff line change
Expand Up @@ -840,7 +840,7 @@ int bdi_writeback_thread(void *data)

/*
* Longest period of inactivity that we tolerate. If we
* see dirty data again later, the task will get
* see dirty data again later, the thread will get
* recreated automatically.
*/
max_idle = max(5UL * 60 * HZ, wait_jiffies);
Expand Down
2 changes: 1 addition & 1 deletion trunk/include/linux/backing-dev.h
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ struct bdi_writeback {

unsigned long last_old_flush; /* last old data flush */

struct task_struct *task; /* writeback task */
struct task_struct *task; /* writeback thread */
struct list_head b_dirty; /* dirty inodes */
struct list_head b_io; /* parked for writeback */
struct list_head b_more_io; /* parked for more writeback */
Expand Down
26 changes: 13 additions & 13 deletions trunk/mm/backing-dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ static struct timer_list sync_supers_timer;
static int bdi_sync_supers(void *);
static void sync_supers_timer_fn(unsigned long);

static void bdi_add_default_flusher_task(struct backing_dev_info *bdi);
static void bdi_add_default_flusher_thread(struct backing_dev_info *bdi);

#ifdef CONFIG_DEBUG_FS
#include <linux/debugfs.h>
Expand Down Expand Up @@ -279,10 +279,10 @@ static void bdi_flush_io(struct backing_dev_info *bdi)
}

/*
* kupdated() used to do this. We cannot do it from the bdi_forker_task()
* kupdated() used to do this. We cannot do it from the bdi_forker_thread()
* or we risk deadlocking on ->s_umount. The longer term solution would be
* to implement sync_supers_bdi() or similar and simply do it from the
* bdi writeback tasks individually.
* bdi writeback thread individually.
*/
static int bdi_sync_supers(void *unused)
{
Expand Down Expand Up @@ -318,7 +318,7 @@ static void sync_supers_timer_fn(unsigned long unused)
bdi_arm_supers_timer();
}

static int bdi_forker_task(void *ptr)
static int bdi_forker_thread(void *ptr)
{
struct bdi_writeback *me = ptr;

Expand Down Expand Up @@ -354,7 +354,7 @@ static int bdi_forker_task(void *ptr)
!bdi_has_dirty_io(bdi))
continue;

bdi_add_default_flusher_task(bdi);
bdi_add_default_flusher_thread(bdi);
}

set_current_state(TASK_INTERRUPTIBLE);
Expand All @@ -376,7 +376,7 @@ static int bdi_forker_task(void *ptr)

/*
* This is our real job - check for pending entries in
* bdi_pending_list, and create the tasks that got added
* bdi_pending_list, and create the threads that got added
*/
bdi = list_entry(bdi_pending_list.next, struct backing_dev_info,
bdi_list);
Expand All @@ -387,7 +387,7 @@ static int bdi_forker_task(void *ptr)
wb->task = kthread_run(bdi_writeback_thread, wb, "flush-%s",
dev_name(bdi->dev));
/*
* If task creation fails, then readd the bdi to
* If thread creation fails, then readd the bdi to
* the pending list and force writeout of the bdi
* from this forker thread. That will free some memory
* and we can try again.
Expand Down Expand Up @@ -430,10 +430,10 @@ static void bdi_add_to_pending(struct rcu_head *head)
}

/*
* Add the default flusher task that gets created for any bdi
* Add the default flusher thread that gets created for any bdi
* that has dirty data pending writeout
*/
void static bdi_add_default_flusher_task(struct backing_dev_info *bdi)
static void bdi_add_default_flusher_thread(struct backing_dev_info *bdi)
{
if (!bdi_cap_writeback_dirty(bdi))
return;
Expand All @@ -445,10 +445,10 @@ void static bdi_add_default_flusher_task(struct backing_dev_info *bdi)
}

/*
* Check with the helper whether to proceed adding a task. Will only
* Check with the helper whether to proceed adding a thread. Will only
* abort if we two or more simultanous calls to
* bdi_add_default_flusher_task() occured, further additions will block
* waiting for previous additions to finish.
* bdi_add_default_flusher_thread() occured, further additions will
* block waiting for previous additions to finish.
*/
if (!test_and_set_bit(BDI_pending, &bdi->state)) {
list_del_rcu(&bdi->bdi_list);
Expand Down Expand Up @@ -506,7 +506,7 @@ int bdi_register(struct backing_dev_info *bdi, struct device *parent,
if (bdi_cap_flush_forker(bdi)) {
struct bdi_writeback *wb = &bdi->wb;

wb->task = kthread_run(bdi_forker_task, wb, "bdi-%s",
wb->task = kthread_run(bdi_forker_thread, wb, "bdi-%s",
dev_name(dev));
if (IS_ERR(wb->task)) {
wb->task = NULL;
Expand Down

0 comments on commit 9cab51e

Please sign in to comment.