Skip to content

Commit

Permalink
regulator: rc5t583: Fix off-by-one valid range checking for selector
Browse files Browse the repository at this point in the history
The valid selector should be 0 ... nsteps-1.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
  • Loading branch information
Axel Lin authored and Mark Brown committed Apr 5, 2012
1 parent 7eb6444 commit 9cc7a45
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/regulator/rc5t583-regulator.c
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ static int rc5t583_set_voltage_sel(struct regulator_dev *rdev,
struct rc5t583_regulator *reg = rdev_get_drvdata(rdev);
struct rc5t583_regulator_info *ri = reg->reg_info;
int ret;
if (selector > ri->nsteps) {
if (selector >= ri->nsteps) {
dev_err(&rdev->dev, "Invalid selector 0x%02x\n", selector);
return -EINVAL;
}
Expand Down

0 comments on commit 9cc7a45

Please sign in to comment.