Skip to content

Commit

Permalink
exofs: Small cleanup of exofs_fill_super
Browse files Browse the repository at this point in the history
Small cleanup that unifies duplicated code used in both the
error and success cases

Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
  • Loading branch information
Boaz Harrosh committed Aug 4, 2011
1 parent 6d4073e commit 9ce7304
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions fs/exofs/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -698,6 +698,8 @@ static int exofs_fill_super(struct super_block *sb, void *data, int silent)
odi.osdname_len = strlen(opts->dev_name);
odi.osdname = (u8 *)opts->dev_name;
od = osduld_info_lookup(&odi);
kfree(opts->dev_name);
opts->dev_name = NULL;
} else {
od = osduld_path_lookup(opts->dev_name);
}
Expand Down Expand Up @@ -806,16 +808,12 @@ static int exofs_fill_super(struct super_block *sb, void *data, int silent)

_exofs_print_device("Mounting", opts->dev_name, sbi->layout.s_ods[0],
sbi->layout.s_pid);
if (opts->is_osdname)
kfree(opts->dev_name);
return 0;

free_sbi:
EXOFS_ERR("Unable to mount exofs on %s pid=0x%llx err=%d\n",
opts->dev_name, sbi->layout.s_pid, ret);
exofs_free_sbi(sbi);
if (opts->is_osdname)
kfree(opts->dev_name);
return ret;
}

Expand Down

0 comments on commit 9ce7304

Please sign in to comment.