Skip to content

Commit

Permalink
s390/smp: remove redundant check
Browse files Browse the repository at this point in the history
condition code "status stored" for sigp sense running always implies
that only the "not running" status bit is set. Therefore no need to
check if it is set.

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
  • Loading branch information
Heiko Carstens authored and Marcelo Tosatti committed Jul 3, 2012
1 parent 36c1ed8 commit 9d04edd
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions arch/s390/kernel/smp.c
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,8 @@ static inline int pcpu_running(struct pcpu *pcpu)
if (__pcpu_sigp(pcpu->address, sigp_sense_running,
0, &pcpu->status) != sigp_status_stored)
return 1;
/* Check for running status */
return !(pcpu->status & 0x400);
/* Status stored condition code is equivalent to cpu not running. */
return 0;
}

/*
Expand Down

0 comments on commit 9d04edd

Please sign in to comment.