Skip to content

Commit

Permalink
firewire: core: fix multichannel IR with buffers larger than 2 GB
Browse files Browse the repository at this point in the history
With a 32-bit i, computing i<<PAGE_SHIFT might result in
an overflow and in an eventual sign-extension.

Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
  • Loading branch information
Clemens Ladisch authored and Stefan Richter committed Jun 17, 2012
1 parent 7baab9a commit 9d23f9e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/firewire/core-iso.c
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ EXPORT_SYMBOL(fw_iso_buffer_destroy);
/* Convert DMA address to offset into virtually contiguous buffer. */
size_t fw_iso_buffer_lookup(struct fw_iso_buffer *buffer, dma_addr_t completed)
{
int i;
size_t i;
dma_addr_t address;
ssize_t offset;

Expand Down

0 comments on commit 9d23f9e

Please sign in to comment.