Skip to content

Commit

Permalink
s390/lcs: cleanup drv attr usage
Browse files Browse the repository at this point in the history
Rename attributes of the lcs_group_driver. Also get rid of
the call to driver_remove_file.

Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Sebastian Ott <sebott@linux.vnet.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
  • Loading branch information
Sebastian Ott authored and Martin Schwidefsky committed May 16, 2012
1 parent 330ce1b commit 9d2aa0a
Showing 1 changed file with 6 additions and 10 deletions.
16 changes: 6 additions & 10 deletions drivers/s390/net/lcs.c
Original file line number Diff line number Diff line change
Expand Up @@ -2432,17 +2432,15 @@ static ssize_t lcs_driver_group_store(struct device_driver *ddrv,
}
static DRIVER_ATTR(group, 0200, NULL, lcs_driver_group_store);

static struct attribute *lcs_group_attrs[] = {
static struct attribute *lcs_drv_attrs[] = {
&driver_attr_group.attr,
NULL,
};

static struct attribute_group lcs_group_attr_group = {
.attrs = lcs_group_attrs,
static struct attribute_group lcs_drv_attr_group = {
.attrs = lcs_drv_attrs,
};

static const struct attribute_group *lcs_group_attr_groups[] = {
&lcs_group_attr_group,
static const struct attribute_group *lcs_drv_attr_groups[] = {
&lcs_drv_attr_group,
NULL,
};

Expand All @@ -2466,7 +2464,7 @@ __init lcs_init_module(void)
rc = ccw_driver_register(&lcs_ccw_driver);
if (rc)
goto ccw_err;
lcs_group_driver.driver.groups = lcs_group_attr_groups;
lcs_group_driver.driver.groups = lcs_drv_attr_groups;
rc = ccwgroup_driver_register(&lcs_group_driver);
if (rc)
goto ccwgroup_err;
Expand All @@ -2492,8 +2490,6 @@ __exit lcs_cleanup_module(void)
{
pr_info("Terminating lcs module.\n");
LCS_DBF_TEXT(0, trace, "cleanup");
driver_remove_file(&lcs_group_driver.driver,
&driver_attr_group);
ccwgroup_driver_unregister(&lcs_group_driver);
ccw_driver_unregister(&lcs_ccw_driver);
root_device_unregister(lcs_root_dev);
Expand Down

0 comments on commit 9d2aa0a

Please sign in to comment.