Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 273372
b: refs/heads/master
c: 981c65a
h: refs/heads/master
v: v3
  • Loading branch information
Julia Lawall authored and Samuel Ortiz committed Oct 24, 2011
1 parent 7d5ac68 commit 9d4b664
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 54d8e2c323b439e0e20ea44d17b875d9a43f7d66
refs/heads/master: 981c65a9b3e24029f64bd45c7a92f901899a033e
9 changes: 5 additions & 4 deletions trunk/drivers/mfd/timberdale.c
Original file line number Diff line number Diff line change
Expand Up @@ -697,21 +697,21 @@ static int __devinit timb_probe(struct pci_dev *dev,
dev_err(&dev->dev, "The driver supports an older "
"version of the FPGA, please update the driver to "
"support %d.%d\n", priv->fw.major, priv->fw.minor);
goto err_ioremap;
goto err_config;
}
if (priv->fw.major < TIMB_SUPPORTED_MAJOR ||
priv->fw.minor < TIMB_REQUIRED_MINOR) {
dev_err(&dev->dev, "The FPGA image is too old (%d.%d), "
"please upgrade the FPGA to at least: %d.%d\n",
priv->fw.major, priv->fw.minor,
TIMB_SUPPORTED_MAJOR, TIMB_REQUIRED_MINOR);
goto err_ioremap;
goto err_config;
}

msix_entries = kzalloc(TIMBERDALE_NR_IRQS * sizeof(*msix_entries),
GFP_KERNEL);
if (!msix_entries)
goto err_ioremap;
goto err_config;

for (i = 0; i < TIMBERDALE_NR_IRQS; i++)
msix_entries[i].entry = i;
Expand Down Expand Up @@ -825,6 +825,8 @@ static int __devinit timb_probe(struct pci_dev *dev,
err_create_file:
pci_disable_msix(dev);
err_msix:
kfree(msix_entries);
err_config:
iounmap(priv->ctl_membase);
err_ioremap:
release_mem_region(priv->ctl_mapbase, CHIPCTLSIZE);
Expand All @@ -833,7 +835,6 @@ static int __devinit timb_probe(struct pci_dev *dev,
err_start:
pci_disable_device(dev);
err_enable:
kfree(msix_entries);
kfree(priv);
pci_set_drvdata(dev, NULL);
return -ENODEV;
Expand Down

0 comments on commit 9d4b664

Please sign in to comment.