Skip to content

Commit

Permalink
block: skip elevator data initialization for flush requests
Browse files Browse the repository at this point in the history
Skip elevator initialization for flush requests by passing priv=0 to
blk_alloc_request() in get_request().  As such elv_set_request() is
never called for flush requests.

Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
  • Loading branch information
Mike Snitzer authored and Jens Axboe committed Feb 11, 2011
1 parent ae1b153 commit 9d5a4e9
Showing 1 changed file with 25 additions and 4 deletions.
29 changes: 25 additions & 4 deletions block/blk-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -737,6 +737,25 @@ static void freed_request(struct request_queue *q, int sync, int priv)
__freed_request(q, sync ^ 1);
}

/*
* Determine if elevator data should be initialized when allocating the
* request associated with @bio.
*/
static bool blk_rq_should_init_elevator(struct bio *bio)
{
if (!bio)
return true;

/*
* Flush requests do not use the elevator so skip initialization.
* This allows a request to share the flush and elevator data.
*/
if (bio->bi_rw & (REQ_FLUSH | REQ_FUA))
return false;

return true;
}

/*
* Get a free request, queue_lock must be held.
* Returns NULL on failure, with queue_lock held.
Expand All @@ -749,7 +768,7 @@ static struct request *get_request(struct request_queue *q, int rw_flags,
struct request_list *rl = &q->rq;
struct io_context *ioc = NULL;
const bool is_sync = rw_is_sync(rw_flags) != 0;
int may_queue, priv;
int may_queue, priv = 0;

may_queue = elv_may_queue(q, rw_flags);
if (may_queue == ELV_MQUEUE_NO)
Expand Down Expand Up @@ -793,9 +812,11 @@ static struct request *get_request(struct request_queue *q, int rw_flags,
rl->count[is_sync]++;
rl->starved[is_sync] = 0;

priv = !test_bit(QUEUE_FLAG_ELVSWITCH, &q->queue_flags);
if (priv)
rl->elvpriv++;
if (blk_rq_should_init_elevator(bio)) {
priv = !test_bit(QUEUE_FLAG_ELVSWITCH, &q->queue_flags);
if (priv)
rl->elvpriv++;
}

if (blk_queue_io_stat(q))
rw_flags |= REQ_IO_STAT;
Expand Down

0 comments on commit 9d5a4e9

Please sign in to comment.