Skip to content

Commit

Permalink
batman-adv: correctly set the data field in the TT_REPONSE packet
Browse files Browse the repository at this point in the history
In the TT_RESPONSE packet, the number of carried entries is not correctly set.
This leads to a wrong interpretation of the packet payload on the receiver side
causing random entries to be added to the global translation table. Therefore
the latter gets always corrupted, triggering a table recovery all the time.

Signed-off-by: Antonio Quartulli <ordex@autistici.org>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
  • Loading branch information
Antonio Quartulli authored and Marek Lindner committed Oct 18, 2011
1 parent 3190126 commit 9d85239
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion net/batman-adv/translation-table.c
Original file line number Diff line number Diff line change
Expand Up @@ -999,7 +999,6 @@ static struct sk_buff *tt_response_fill_table(uint16_t tt_len, uint8_t ttvn,
tt_response = (struct tt_query_packet *)skb_put(skb,
tt_query_size + tt_len);
tt_response->ttvn = ttvn;
tt_response->tt_data = htons(tt_tot);

tt_change = (struct tt_change *)(skb->data + tt_query_size);
tt_count = 0;
Expand All @@ -1025,6 +1024,10 @@ static struct sk_buff *tt_response_fill_table(uint16_t tt_len, uint8_t ttvn,
}
rcu_read_unlock();

/* store in the message the number of entries we have successfully
* copied */
tt_response->tt_data = htons(tt_count);

out:
return skb;
}
Expand Down

0 comments on commit 9d85239

Please sign in to comment.