Skip to content

Commit

Permalink
Bluetooth: Fix EIR data generation for mgmt_device_found
Browse files Browse the repository at this point in the history
The mgmt_device_found function expects to receive only the significant
part of the EIR data so it needs to be removed before calling the
function. This patch adds a new eir_get_length() helper function to
calculate the length of the significant part.

Signed-off-by: Vishal Agarwal <vishal.agarwal@stericsson.com>
Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
  • Loading branch information
Vishal Agarwal authored and Gustavo Padovan committed May 16, 2012
1 parent a24299e commit 9d939d9
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 1 deletion.
17 changes: 17 additions & 0 deletions include/net/bluetooth/hci_core.h
Original file line number Diff line number Diff line change
Expand Up @@ -926,6 +926,23 @@ static inline bool eir_has_data_type(u8 *data, size_t data_len, u8 type)
return false;
}

static inline size_t eir_get_length(u8 *eir, size_t eir_len)
{
size_t parsed = 0;

while (parsed < eir_len) {
u8 field_len = eir[0];

if (field_len == 0)
return parsed;

parsed += field_len + 1;
eir += field_len + 1;
}

return eir_len;
}

static inline u16 eir_append_data(u8 *eir, u16 eir_len, u8 type, u8 *data,
u8 data_len)
{
Expand Down
4 changes: 3 additions & 1 deletion net/bluetooth/hci_event.c
Original file line number Diff line number Diff line change
Expand Up @@ -3001,6 +3001,7 @@ static inline void hci_extended_inquiry_result_evt(struct hci_dev *hdev, struct
struct inquiry_data data;
struct extended_inquiry_info *info = (void *) (skb->data + 1);
int num_rsp = *((__u8 *) skb->data);
size_t eir_len;

BT_DBG("%s num_rsp %d", hdev->name, num_rsp);

Expand Down Expand Up @@ -3033,9 +3034,10 @@ static inline void hci_extended_inquiry_result_evt(struct hci_dev *hdev, struct

name_known = hci_inquiry_cache_update(hdev, &data, name_known,
&ssp);
eir_len = eir_get_length(info->data, sizeof(info->data));
mgmt_device_found(hdev, &info->bdaddr, ACL_LINK, 0x00,
info->dev_class, info->rssi, !name_known,
ssp, info->data, sizeof(info->data));
ssp, info->data, eir_len);
}

hci_dev_unlock(hdev);
Expand Down

0 comments on commit 9d939d9

Please sign in to comment.