Skip to content

Commit

Permalink
V4L/DVB (8791): v4l2-dev: do not clear the driver_data field
Browse files Browse the repository at this point in the history
The driver_data field of the device structure was zeroed, thus losing
this information. Many drivers set this up before calling
video_device_register, so we have to ensure that it isn't lost.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Hans Verkuil authored and Mauro Carvalho Chehab committed Oct 12, 2008
1 parent c170ecf commit 9d95af9
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/media/video/v4l2-dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ int video_register_device_index(struct video_device *vfd, int type, int nr,
int end;
int ret;
char *name_base;
void *priv = video_get_drvdata(vfd);

/* the release callback MUST be present */
BUG_ON(!vfd->release);
Expand Down Expand Up @@ -295,6 +296,9 @@ int video_register_device_index(struct video_device *vfd, int type, int nr,

/* sysfs class */
memset(&vfd->dev, 0, sizeof(vfd->dev));
/* The memset above cleared the device's drvdata, so
put back the copy we made earlier. */
video_set_drvdata(vfd, priv);
vfd->dev.class = &video_class;
vfd->dev.devt = MKDEV(VIDEO_MAJOR, vfd->minor);
if (vfd->parent)
Expand Down

0 comments on commit 9d95af9

Please sign in to comment.