Skip to content

Commit

Permalink
libata: Remove FIXME comment in atapi_eh_request_sense
Browse files Browse the repository at this point in the history
Remove the FIXME comment in  atapi_eh_request_sense () asking whether
memset of sense buffer is necessary.  The buffer may be partially or
fully filled by the device.  We want it to be cleared.

Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
  • Loading branch information
Nicholas Krause authored and Tejun Heo committed Jan 7, 2015
1 parent a3a84bc commit 9d9acda
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/ata/libata-eh.c
Original file line number Diff line number Diff line change
Expand Up @@ -1635,7 +1635,6 @@ unsigned int atapi_eh_request_sense(struct ata_device *dev,

DPRINTK("ATAPI request sense\n");

/* FIXME: is this needed? */
memset(sense_buf, 0, SCSI_SENSE_BUFFERSIZE);

/* initialize sense_buf with the error register,
Expand Down

0 comments on commit 9d9acda

Please sign in to comment.