Skip to content

Commit

Permalink
USB: fix gregkh-usb-usb-sisusb2vga-convert-printk-to-dev_-macros
Browse files Browse the repository at this point in the history
drivers/usb/misc/sisusbvga/sisusb.c: In function 'sisusb_open':
drivers/usb/misc/sisusbvga/sisusb.c:2444: warning: 'sisusb' is used uninitialized in this function

I can tell that'll oops just by looking at it.

How come this code assume a 7,000 column xterm? :(

Cc: Felipe Balbi <felipe.lima@indt.org.br>
Cc: Thomas <thomas@winischhofer.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Andrew Morton authored and Greg Kroah-Hartman committed Oct 12, 2007
1 parent ca0677a commit 9dcfbd9
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions drivers/usb/misc/sisusbvga/sisusb.c
Original file line number Diff line number Diff line change
Expand Up @@ -3323,15 +3323,7 @@ static int __init usb_sisusb_init(void)
sisusb_init_concode();
#endif

if (!(retval = usb_register(&sisusb_driver))) {

dev_info(&sisusb->sisusb_dev->dev, "Driver version %d.%d.%d\n", SISUSB_VERSION,
SISUSB_REVISION, SISUSB_PATCHLEVEL);
dev_info(&sisusb->sisusb_dev->dev, "sisusb: Copyright (C) 2005 Thomas Winischhofer\n");

}

return retval;
return usb_register(&sisusb_driver);
}

static void __exit usb_sisusb_exit(void)
Expand Down

0 comments on commit 9dcfbd9

Please sign in to comment.