Skip to content

Commit

Permalink
cciss: Clear all sysfs-exposed data for deleted logical drives.
Browse files Browse the repository at this point in the history
When removing a logical drive, clear all the information that is
now exposed by sysfs (e.g. vendor, model, serial number.)

Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
  • Loading branch information
Stephen M. Cameron authored and Jens Axboe committed Oct 1, 2009
1 parent 8ce5196 commit 9ddb27b
Showing 1 changed file with 21 additions and 10 deletions.
31 changes: 21 additions & 10 deletions drivers/block/cciss.c
Original file line number Diff line number Diff line change
Expand Up @@ -2134,6 +2134,25 @@ static int rebuild_lun_table(ctlr_info_t *h, int first_time)
goto freeret;
}

static void cciss_clear_drive_info(drive_info_struct *drive_info)
{
/* zero out the disk size info */
drive_info->nr_blocks = 0;
drive_info->block_size = 0;
drive_info->heads = 0;
drive_info->sectors = 0;
drive_info->cylinders = 0;
drive_info->raid_level = -1;
memset(drive_info->serial_no, 0, sizeof(drive_info->serial_no));
memset(drive_info->model, 0, sizeof(drive_info->model));
memset(drive_info->rev, 0, sizeof(drive_info->rev));
memset(drive_info->vendor, 0, sizeof(drive_info->vendor));
/*
* don't clear the LUNID though, we need to remember which
* one this one is.
*/
}

/* This function will deregister the disk and it's queue from the
* kernel. It must be called with the controller lock held and the
* drv structures busy_configuring flag set. It's parameters are:
Expand Down Expand Up @@ -2212,16 +2231,8 @@ static int deregister_disk(ctlr_info_t *h, int drv_index,
}

--h->num_luns;
/* zero out the disk size info */
drv->nr_blocks = 0;
drv->block_size = 0;
drv->heads = 0;
drv->sectors = 0;
drv->cylinders = 0;
drv->raid_level = -1; /* This can be used as a flag variable to
* indicate that this element of the drive
* array is free.
*/
cciss_clear_drive_info(drv);

if (clear_all) {
/* check to see if it was the last disk */
if (drv == h->drv + h->highest_lun) {
Expand Down

0 comments on commit 9ddb27b

Please sign in to comment.