Skip to content

Commit

Permalink
iommu/amd: Make sure IOMMU interrupts are re-enabled on resume
Browse files Browse the repository at this point in the history
Unfortunatly the interrupts for the event log and the
peripheral page-faults are only enabled at boot but not
re-enabled at resume. Fix that.

Cc: stable@vger.kernel.org
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
  • Loading branch information
Joerg Roedel committed Mar 15, 2012
1 parent cebd5fa commit 9ddd592
Showing 1 changed file with 20 additions and 10 deletions.
30 changes: 20 additions & 10 deletions drivers/iommu/amd_iommu_init.c
Original file line number Diff line number Diff line change
Expand Up @@ -1123,8 +1123,9 @@ static int iommu_setup_msi(struct amd_iommu *iommu)
{
int r;

if (pci_enable_msi(iommu->dev))
return 1;
r = pci_enable_msi(iommu->dev);
if (r)
return r;

r = request_threaded_irq(iommu->dev->irq,
amd_iommu_int_handler,
Expand All @@ -1134,27 +1135,36 @@ static int iommu_setup_msi(struct amd_iommu *iommu)

if (r) {
pci_disable_msi(iommu->dev);
return 1;
return r;
}

iommu->int_enabled = true;
iommu_feature_enable(iommu, CONTROL_EVT_INT_EN);

if (iommu->ppr_log != NULL)
iommu_feature_enable(iommu, CONTROL_PPFINT_EN);

return 0;
}

static int iommu_init_msi(struct amd_iommu *iommu)
{
int ret;

if (iommu->int_enabled)
return 0;
goto enable_faults;

if (pci_find_capability(iommu->dev, PCI_CAP_ID_MSI))
return iommu_setup_msi(iommu);
ret = iommu_setup_msi(iommu);
else
ret = -ENODEV;

return 1;
if (ret)
return ret;

enable_faults:
iommu_feature_enable(iommu, CONTROL_EVT_INT_EN);

if (iommu->ppr_log != NULL)
iommu_feature_enable(iommu, CONTROL_PPFINT_EN);

return 0;
}

/****************************************************************************
Expand Down

0 comments on commit 9ddd592

Please sign in to comment.