Skip to content

Commit

Permalink
ipmi: remove driver_data direct access of struct device
Browse files Browse the repository at this point in the history
In the near future, the driver core is going to not allow direct access
to the driver_data pointer in struct device.  Instead, the functions
dev_get_drvdata() and dev_set_drvdata() should be used.  These functions
have been around since the beginning, so are backwards compatible with
all older kernel versions.

Cc: openipmi-developer@lists.sourceforge.net
Acked-by: Corey Minyard <minyard@acm.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Greg Kroah-Hartman committed Jun 16, 2009
1 parent f899c2d commit 9de33df
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/char/ipmi/ipmi_si_intf.c
Original file line number Diff line number Diff line change
Expand Up @@ -2375,14 +2375,14 @@ static int __devinit ipmi_of_probe(struct of_device *dev,
info->io.addr_data, info->io.regsize, info->io.regspacing,
info->irq);

dev->dev.driver_data = (void *) info;
dev_set_drvdata(&dev->dev, info);

return try_smi_init(info);
}

static int __devexit ipmi_of_remove(struct of_device *dev)
{
cleanup_one_si(dev->dev.driver_data);
cleanup_one_si(dev_get_drvdata(&dev->dev));
return 0;
}

Expand Down

0 comments on commit 9de33df

Please sign in to comment.