Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 42915
b: refs/heads/master
c: e9d55f9
h: refs/heads/master
i:
  42913: 81850ac
  42911: 04ce238
v: v3
  • Loading branch information
Evgeniy Polyakov authored and Linus Torvalds committed Dec 7, 2006
1 parent 59fe69c commit 9e18ea9
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 24 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: ec0837f230e57afde65db72539e748d2a75abed0
refs/heads/master: e9d55f9dbcf048a882478b437fa3f87becf8a770
4 changes: 0 additions & 4 deletions trunk/drivers/w1/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@
# Makefile for the Dallas's 1-wire bus.
#

ifeq ($(CONFIG_W1_DS2433_CRC), y)
EXTRA_CFLAGS += -DCONFIG_W1_F23_CRC
endif

obj-$(CONFIG_W1) += wire.o
wire-objs := w1.o w1_int.o w1_family.o w1_netlink.o w1_io.o

Expand Down
4 changes: 0 additions & 4 deletions trunk/drivers/w1/slaves/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@
# Makefile for the Dallas's 1-wire slaves.
#

ifeq ($(CONFIG_W1_SLAVE_DS2433_CRC), y)
EXTRA_CFLAGS += -DCONFIG_W1_F23_CRC
endif

obj-$(CONFIG_W1_SLAVE_THERM) += w1_therm.o
obj-$(CONFIG_W1_SLAVE_SMEM) += w1_smem.o
obj-$(CONFIG_W1_SLAVE_DS2433) += w1_ds2433.o
Expand Down
30 changes: 15 additions & 15 deletions trunk/drivers/w1/slaves/w1_ds2433.c
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
#include <linux/device.h>
#include <linux/types.h>
#include <linux/delay.h>
#ifdef CONFIG_W1_F23_CRC
#ifdef CONFIG_W1_SLAVE_DS2433_CRC
#include <linux/crc16.h>

#define CRC16_INIT 0
Expand Down Expand Up @@ -62,7 +62,7 @@ static inline size_t w1_f23_fix_count(loff_t off, size_t count, size_t size)
return count;
}

#ifdef CONFIG_W1_F23_CRC
#ifdef CONFIG_W1_SLAVE_DS2433_CRC
static int w1_f23_refresh_block(struct w1_slave *sl, struct w1_f23_data *data,
int block)
{
Expand All @@ -89,13 +89,13 @@ static int w1_f23_refresh_block(struct w1_slave *sl, struct w1_f23_data *data,

return 0;
}
#endif /* CONFIG_W1_F23_CRC */
#endif /* CONFIG_W1_SLAVE_DS2433_CRC */

static ssize_t w1_f23_read_bin(struct kobject *kobj, char *buf, loff_t off,
size_t count)
{
struct w1_slave *sl = kobj_to_w1_slave(kobj);
#ifdef CONFIG_W1_F23_CRC
#ifdef CONFIG_W1_SLAVE_DS2433_CRC
struct w1_f23_data *data = sl->family_data;
int i, min_page, max_page;
#else
Expand All @@ -107,7 +107,7 @@ static ssize_t w1_f23_read_bin(struct kobject *kobj, char *buf, loff_t off,

mutex_lock(&sl->master->mutex);

#ifdef CONFIG_W1_F23_CRC
#ifdef CONFIG_W1_SLAVE_DS2433_CRC

min_page = (off >> W1_PAGE_BITS);
max_page = (off + count - 1) >> W1_PAGE_BITS;
Expand All @@ -119,7 +119,7 @@ static ssize_t w1_f23_read_bin(struct kobject *kobj, char *buf, loff_t off,
}
memcpy(buf, &data->memory[off], count);

#else /* CONFIG_W1_F23_CRC */
#else /* CONFIG_W1_SLAVE_DS2433_CRC */

/* read directly from the EEPROM */
if (w1_reset_select_slave(sl)) {
Expand All @@ -133,7 +133,7 @@ static ssize_t w1_f23_read_bin(struct kobject *kobj, char *buf, loff_t off,
w1_write_block(sl->master, wrbuf, 3);
w1_read_block(sl->master, buf, count);

#endif /* CONFIG_W1_F23_CRC */
#endif /* CONFIG_W1_SLAVE_DS2433_CRC */

out_up:
mutex_unlock(&sl->master->mutex);
Expand Down Expand Up @@ -208,7 +208,7 @@ static ssize_t w1_f23_write_bin(struct kobject *kobj, char *buf, loff_t off,
if ((count = w1_f23_fix_count(off, count, W1_EEPROM_SIZE)) == 0)
return 0;

#ifdef CONFIG_W1_F23_CRC
#ifdef CONFIG_W1_SLAVE_DS2433_CRC
/* can only write full blocks in cached mode */
if ((off & W1_PAGE_MASK) || (count & W1_PAGE_MASK)) {
dev_err(&sl->dev, "invalid offset/count off=%d cnt=%zd\n",
Expand All @@ -223,7 +223,7 @@ static ssize_t w1_f23_write_bin(struct kobject *kobj, char *buf, loff_t off,
return -EINVAL;
}
}
#endif /* CONFIG_W1_F23_CRC */
#endif /* CONFIG_W1_SLAVE_DS2433_CRC */

mutex_lock(&sl->master->mutex);

Expand Down Expand Up @@ -262,7 +262,7 @@ static struct bin_attribute w1_f23_bin_attr = {
static int w1_f23_add_slave(struct w1_slave *sl)
{
int err;
#ifdef CONFIG_W1_F23_CRC
#ifdef CONFIG_W1_SLAVE_DS2433_CRC
struct w1_f23_data *data;

data = kmalloc(sizeof(struct w1_f23_data), GFP_KERNEL);
Expand All @@ -271,24 +271,24 @@ static int w1_f23_add_slave(struct w1_slave *sl)
memset(data, 0, sizeof(struct w1_f23_data));
sl->family_data = data;

#endif /* CONFIG_W1_F23_CRC */
#endif /* CONFIG_W1_SLAVE_DS2433_CRC */

err = sysfs_create_bin_file(&sl->dev.kobj, &w1_f23_bin_attr);

#ifdef CONFIG_W1_F23_CRC
#ifdef CONFIG_W1_SLAVE_DS2433_CRC
if (err)
kfree(data);
#endif /* CONFIG_W1_F23_CRC */
#endif /* CONFIG_W1_SLAVE_DS2433_CRC */

return err;
}

static void w1_f23_remove_slave(struct w1_slave *sl)
{
#ifdef CONFIG_W1_F23_CRC
#ifdef CONFIG_W1_SLAVE_DS2433_CRC
kfree(sl->family_data);
sl->family_data = NULL;
#endif /* CONFIG_W1_F23_CRC */
#endif /* CONFIG_W1_SLAVE_DS2433_CRC */
sysfs_remove_bin_file(&sl->dev.kobj, &w1_f23_bin_attr);
}

Expand Down

0 comments on commit 9e18ea9

Please sign in to comment.