Skip to content

Commit

Permalink
simplefb: use write-combined remapping
Browse files Browse the repository at this point in the history
Framebuffers shouldn't be cached and it is usually very uncommon to read
them. Therefore, use ioremap_wc() to get significant speed improvements on
systems which provide it. On all other systems it's aliased to
ioremap_nocache() which is also fine.

Reported-by: Tom Gundersen <teg@jklm.no>
Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
Tested-by: Tom Gundersen <teg@jklm.no>
Tested-by: Alexandre Courbot <acourbot@nvidia.com>
Tested-by: Stephen Warren <swarren@wwwdotorg.org>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
  • Loading branch information
David Herrmann authored and Tomi Valkeinen committed Oct 30, 2013
1 parent 498f6d3 commit 9e210be
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/video/simplefb.c
Original file line number Diff line number Diff line change
Expand Up @@ -219,8 +219,8 @@ static int simplefb_probe(struct platform_device *pdev)

info->fbops = &simplefb_ops;
info->flags = FBINFO_DEFAULT | FBINFO_MISC_FIRMWARE;
info->screen_base = ioremap(info->fix.smem_start,
info->fix.smem_len);
info->screen_base = ioremap_wc(info->fix.smem_start,
info->fix.smem_len);
if (!info->screen_base) {
framebuffer_release(info);
return -ENODEV;
Expand Down

0 comments on commit 9e210be

Please sign in to comment.