Skip to content

Commit

Permalink
[PATCH] md: raid1_quiesce is back to front, fix it.
Browse files Browse the repository at this point in the history
A state of 0 mean 'not quiesced'
A state of 1 means 'is quiesced'

The original code got this wrong.

Signed-off-by: Neil Brown <neilb@cse.unsw.edu.au>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
NeilBrown authored and Linus Torvalds committed Sep 9, 2005
1 parent 15945fe commit 9e6603d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/md/raid1.c
Original file line number Diff line number Diff line change
Expand Up @@ -1708,14 +1708,14 @@ void raid1_quiesce(mddev_t *mddev, int state)
conf_t *conf = mddev_to_conf(mddev);

switch(state) {
case 0:
case 1:
spin_lock_irq(&conf->resync_lock);
conf->barrier++;
wait_event_lock_irq(conf->wait_idle, !conf->nr_pending,
conf->resync_lock, raid1_unplug(mddev->queue));
spin_unlock_irq(&conf->resync_lock);
break;
case 1:
case 0:
spin_lock_irq(&conf->resync_lock);
conf->barrier--;
spin_unlock_irq(&conf->resync_lock);
Expand Down

0 comments on commit 9e6603d

Please sign in to comment.