Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 296265
b: refs/heads/master
c: 41569e3
h: refs/heads/master
i:
  296263: f5ba9a2
v: v3
  • Loading branch information
Russell King committed Mar 24, 2012
1 parent e0ca8ba commit 9e7b1c5
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 11 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 2b7da084d484fe0dd831464993e2abb496402eb8
refs/heads/master: 41569e370c5e1f5714a3386a3795efff99891f97
6 changes: 3 additions & 3 deletions trunk/arch/arm/mach-rpc/ecard.c
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@ ecard_irq_handler(unsigned int irq, struct irq_desc *desc)
for (ec = cards; ec; ec = ec->next) {
int pending;

if (!ec->claimed || ec->irq == NO_IRQ || ec->slot_no == 8)
if (!ec->claimed || !ec->irq || ec->slot_no == 8)
continue;

if (ec->ops && ec->ops->irqpending)
Expand Down Expand Up @@ -710,8 +710,8 @@ static struct expansion_card *__init ecard_alloc_card(int type, int slot)

ec->slot_no = slot;
ec->easi = type == ECARD_EASI;
ec->irq = NO_IRQ;
ec->fiq = NO_IRQ;
ec->irq = 0;
ec->fiq = 0;
ec->dma = NO_DMA;
ec->ops = &ecard_default_ops;

Expand Down
2 changes: 1 addition & 1 deletion trunk/drivers/scsi/arm/arxescsi.c
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ arxescsi_probe(struct expansion_card *ec, const struct ecard_id *id)
info->base = base;

info->info.scsi.io_base = base + 0x2000;
info->info.scsi.irq = NO_IRQ;
info->info.scsi.irq = 0;
info->info.scsi.dma = NO_DMA;
info->info.scsi.io_shift = 5;
info->info.ifcfg.clockrate = 24; /* MHz */
Expand Down
4 changes: 2 additions & 2 deletions trunk/drivers/scsi/arm/fas216.c
Original file line number Diff line number Diff line change
Expand Up @@ -2176,7 +2176,7 @@ static void fas216_done(FAS216_Info *info, unsigned int result)
fn = (void (*)(FAS216_Info *, struct scsi_cmnd *, unsigned int))SCpnt->host_scribble;
fn(info, SCpnt, result);

if (info->scsi.irq != NO_IRQ) {
if (info->scsi.irq) {
spin_lock_irqsave(&info->host_lock, flags);
if (info->scsi.phase == PHASE_IDLE)
fas216_kick(info);
Expand Down Expand Up @@ -2276,7 +2276,7 @@ static int fas216_noqueue_command_lck(struct scsi_cmnd *SCpnt,
* We should only be using this if we don't have an interrupt.
* Provide some "incentive" to use the queueing code.
*/
BUG_ON(info->scsi.irq != NO_IRQ);
BUG_ON(info->scsi.irq);

info->internal_done = 0;
fas216_queue_command_lck(SCpnt, fas216_internal_done);
Expand Down
4 changes: 0 additions & 4 deletions trunk/drivers/scsi/arm/fas216.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@
#ifndef FAS216_H
#define FAS216_H

#ifndef NO_IRQ
#define NO_IRQ 255
#endif

#include <scsi/scsi_eh.h>

#include "queue.h"
Expand Down

0 comments on commit 9e7b1c5

Please sign in to comment.