Skip to content

Commit

Permalink
nvram: Drop the bkl from non-generic nvram_llseek()
Browse files Browse the repository at this point in the history
Drop the bkl from nvram_llseek() as it obviously protects nothing.
The file offset is safe in essence.

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <1255116426-7270-1-git-send-email-fweisbec@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Frederic Weisbecker authored and Thomas Gleixner committed Oct 14, 2009
1 parent 6783b9c commit 9e8ab74
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/char/nvram.c
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
#define NVRAM_VERSION "1.3"

#include <linux/module.h>
#include <linux/smp_lock.h>
#include <linux/nvram.h>

#define PC 1
Expand Down Expand Up @@ -214,7 +213,6 @@ void nvram_set_checksum(void)

static loff_t nvram_llseek(struct file *file, loff_t offset, int origin)
{
lock_kernel();
switch (origin) {
case 0:
/* nothing to do */
Expand All @@ -226,7 +224,7 @@ static loff_t nvram_llseek(struct file *file, loff_t offset, int origin)
offset += NVRAM_BYTES;
break;
}
unlock_kernel();

return (offset >= 0) ? (file->f_pos = offset) : -EINVAL;
}

Expand Down

0 comments on commit 9e8ab74

Please sign in to comment.