Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 136577
b: refs/heads/master
c: d1d7cae
h: refs/heads/master
i:
  136575: 3200d94
v: v3
  • Loading branch information
Ingo Molnar committed Jan 28, 2009
1 parent 1264703 commit 9e90dc8
Show file tree
Hide file tree
Showing 13 changed files with 30 additions and 28 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: bdb1a9b62fc182d4da3143e346f7a0925d243352
refs/heads/master: d1d7cae8fd54a301a0de531b48451649933ffdcf
9 changes: 5 additions & 4 deletions trunk/arch/x86/include/asm/bigsmp/apic.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,15 @@ static inline const cpumask_t *bigsmp_target_cpus(void)
#define APIC_DFR_VALUE (APIC_DFR_FLAT)
#define NO_BALANCE_IRQ (0)

static inline unsigned long check_apicid_used(physid_mask_t bitmap, int apicid)
static inline unsigned long
bigsmp_check_apicid_used(physid_mask_t bitmap, int apicid)
{
return (0);
return 0;
}

static inline unsigned long check_apicid_present(int bit)
static inline unsigned long bigsmp_check_apicid_present(int bit)
{
return (1);
return 1;
}

static inline unsigned long calculate_ldr(int cpu)
Expand Down
5 changes: 3 additions & 2 deletions trunk/arch/x86/include/asm/es7000/apic.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,12 @@ static inline const cpumask_t *es7000_target_cpus(void)
#define APIC_DFR_VALUE (APIC_DFR_FLAT)
#define NO_BALANCE_IRQ (0)

static inline unsigned long check_apicid_used(physid_mask_t bitmap, int apicid)
static inline unsigned long
es7000_check_apicid_used(physid_mask_t bitmap, int apicid)
{
return 0;
}
static inline unsigned long check_apicid_present(int bit)
static inline unsigned long es7000_check_apicid_present(int bit)
{
return physid_isset(bit, phys_cpu_present_map);
}
Expand Down
4 changes: 2 additions & 2 deletions trunk/arch/x86/include/asm/mach-default/mach_apic.h
Original file line number Diff line number Diff line change
Expand Up @@ -105,12 +105,12 @@ static inline void vector_allocation_domain(int cpu, struct cpumask *retmask)
}
#endif

static inline unsigned long check_apicid_used(physid_mask_t bitmap, int apicid)
static inline unsigned long default_check_apicid_used(physid_mask_t bitmap, int apicid)
{
return physid_isset(apicid, bitmap);
}

static inline unsigned long check_apicid_present(int bit)
static inline unsigned long default_check_apicid_present(int bit)
{
return physid_isset(bit, phys_cpu_present_map);
}
Expand Down
2 changes: 0 additions & 2 deletions trunk/arch/x86/include/asm/mach-generic/mach_apic.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@
#define cpu_present_to_apicid (apic->cpu_present_to_apicid)
#define apicid_to_cpu_present (apic->apicid_to_cpu_present)
#define setup_portio_remap (apic->setup_portio_remap)
#define check_apicid_present (apic->check_apicid_present)
#define check_phys_apicid_present (apic->check_phys_apicid_present)
#define check_apicid_used (apic->check_apicid_used)
#define cpu_mask_to_apicid (apic->cpu_mask_to_apicid)
#define cpu_mask_to_apicid_and (apic->cpu_mask_to_apicid_and)
#define vector_allocation_domain (apic->vector_allocation_domain)
Expand Down
5 changes: 3 additions & 2 deletions trunk/arch/x86/include/asm/numaq/apic.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,12 @@ static inline const cpumask_t *numaq_target_cpus(void)

#define NO_BALANCE_IRQ (1)

static inline unsigned long check_apicid_used(physid_mask_t bitmap, int apicid)
static inline unsigned long
numaq_check_apicid_used(physid_mask_t bitmap, int apicid)
{
return physid_isset(apicid, bitmap);
}
static inline unsigned long check_apicid_present(int bit)
static inline unsigned long numaq_check_apicid_present(int bit)
{
return physid_isset(bit, phys_cpu_present_map);
}
Expand Down
5 changes: 3 additions & 2 deletions trunk/arch/x86/include/asm/summit/apic.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,14 @@ static inline const cpumask_t *summit_target_cpus(void)
return &cpumask_of_cpu(0);
}

static inline unsigned long check_apicid_used(physid_mask_t bitmap, int apicid)
static inline unsigned long
summit_check_apicid_used(physid_mask_t bitmap, int apicid)
{
return 0;
}

/* we don't use the phys_cpu_present_map to indicate apicid presence */
static inline unsigned long check_apicid_present(int bit)
static inline unsigned long summit_check_apicid_present(int bit)
{
return 1;
}
Expand Down
6 changes: 3 additions & 3 deletions trunk/arch/x86/kernel/io_apic.c
Original file line number Diff line number Diff line change
Expand Up @@ -2135,7 +2135,7 @@ static void __init setup_ioapic_ids_from_mpc(void)
* system must have a unique ID or we get lots of nice
* 'stuck on smp_invalidate_needed IPI wait' messages.
*/
if (check_apicid_used(phys_id_present_map,
if (apic->check_apicid_used(phys_id_present_map,
mp_ioapics[apic_id].apicid)) {
printk(KERN_ERR "BIOS bug, IO-APIC#%d ID %d is already used!...\n",
apic_id, mp_ioapics[apic_id].apicid);
Expand Down Expand Up @@ -3878,10 +3878,10 @@ int __init io_apic_get_unique_id(int ioapic, int apic_id)
* Every APIC in a system must have a unique ID or we get lots of nice
* 'stuck on smp_invalidate_needed IPI wait' messages.
*/
if (check_apicid_used(apic_id_map, apic_id)) {
if (apic->check_apicid_used(apic_id_map, apic_id)) {

for (i = 0; i < get_physical_broadcast(); i++) {
if (!check_apicid_used(apic_id_map, i))
if (!apic->check_apicid_used(apic_id_map, i))
break;
}

Expand Down
4 changes: 2 additions & 2 deletions trunk/arch/x86/mach-generic/bigsmp.c
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ struct genapic apic_bigsmp = {
.target_cpus = bigsmp_target_cpus,
.disable_esr = 1,
.dest_logical = 0,
.check_apicid_used = check_apicid_used,
.check_apicid_present = check_apicid_present,
.check_apicid_used = bigsmp_check_apicid_used,
.check_apicid_present = bigsmp_check_apicid_present,

.no_balance_irq = NO_BALANCE_IRQ,
.no_ioapic_check = 0,
Expand Down
4 changes: 2 additions & 2 deletions trunk/arch/x86/mach-generic/default.c
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ struct genapic apic_default = {
.target_cpus = default_target_cpus,
.disable_esr = 0,
.dest_logical = APIC_DEST_LOGICAL,
.check_apicid_used = check_apicid_used,
.check_apicid_present = check_apicid_present,
.check_apicid_used = default_check_apicid_used,
.check_apicid_present = default_check_apicid_present,

.no_balance_irq = NO_BALANCE_IRQ,
.no_ioapic_check = 0,
Expand Down
4 changes: 2 additions & 2 deletions trunk/arch/x86/mach-generic/es7000.c
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ struct genapic apic_es7000 = {
.target_cpus = es7000_target_cpus,
.disable_esr = 1,
.dest_logical = 0,
.check_apicid_used = check_apicid_used,
.check_apicid_present = check_apicid_present,
.check_apicid_used = es7000_check_apicid_used,
.check_apicid_present = es7000_check_apicid_present,

.no_balance_irq = NO_BALANCE_IRQ,
.no_ioapic_check = 0,
Expand Down
4 changes: 2 additions & 2 deletions trunk/arch/x86/mach-generic/numaq.c
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ struct genapic apic_numaq = {
.target_cpus = numaq_target_cpus,
.disable_esr = 1,
.dest_logical = APIC_DEST_LOGICAL,
.check_apicid_used = check_apicid_used,
.check_apicid_present = check_apicid_present,
.check_apicid_used = numaq_check_apicid_used,
.check_apicid_present = numaq_check_apicid_present,

.no_balance_irq = NO_BALANCE_IRQ,
.no_ioapic_check = 0,
Expand Down
4 changes: 2 additions & 2 deletions trunk/arch/x86/mach-generic/summit.c
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ struct genapic apic_summit = {
.target_cpus = summit_target_cpus,
.disable_esr = 1,
.dest_logical = APIC_DEST_LOGICAL,
.check_apicid_used = check_apicid_used,
.check_apicid_present = check_apicid_present,
.check_apicid_used = summit_check_apicid_used,
.check_apicid_present = summit_check_apicid_present,

.no_balance_irq = NO_BALANCE_IRQ,
.no_ioapic_check = 0,
Expand Down

0 comments on commit 9e90dc8

Please sign in to comment.