Skip to content

Commit

Permalink
ARM: EXYNOS: Remove a new bus_type instance for EXYNOS5
Browse files Browse the repository at this point in the history
A seperate bus_type instance is not required for EXYNOS5. The
existing bus_type instance used with EXYNOS4 is sufficient for
both EXYNOS4 and EXYNOS5. This also solves issue of uninitialized
usage of exynos4_subsys in EXYNOS4 power management code that is
reused for EXYNOS5 also. In addition to that, the existing
exynos4_subsys bus_type is renamed to exynos_subsys to indicate
that it is reused on both EXYNOS4 and EXYNOS5 platforms.

Signed-off-by: Thomas Abraham <thomas.abraham@linaro.org>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
  • Loading branch information
Thomas Abraham authored and Kukjin Kim committed May 15, 2012
1 parent 3a08f7f commit 9ee6af9
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 23 deletions.
27 changes: 6 additions & 21 deletions arch/arm/mach-exynos/common.c
Original file line number Diff line number Diff line change
Expand Up @@ -565,30 +565,18 @@ void __init exynos5_init_irq(void)
s5p_init_irq(NULL, 0);
}

struct bus_type exynos4_subsys = {
.name = "exynos4-core",
.dev_name = "exynos4-core",
};

struct bus_type exynos5_subsys = {
.name = "exynos5-core",
.dev_name = "exynos5-core",
struct bus_type exynos_subsys = {
.name = "exynos-core",
.dev_name = "exynos-core",
};

static struct device exynos4_dev = {
.bus = &exynos4_subsys,
};

static struct device exynos5_dev = {
.bus = &exynos5_subsys,
.bus = &exynos_subsys,
};

static int __init exynos_core_init(void)
{
if (soc_is_exynos5250())
return subsys_system_register(&exynos5_subsys, NULL);
else
return subsys_system_register(&exynos4_subsys, NULL);
return subsys_system_register(&exynos_subsys, NULL);
}
core_initcall(exynos_core_init);

Expand Down Expand Up @@ -675,10 +663,7 @@ static int __init exynos_init(void)
{
printk(KERN_INFO "EXYNOS: Initializing architecture\n");

if (soc_is_exynos5250())
return device_register(&exynos5_dev);
else
return device_register(&exynos4_dev);
return device_register(&exynos4_dev);
}

/* uart registration process */
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/mach-exynos/pm.c
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ static void exynos4_restore_pll(void)

static struct subsys_interface exynos4_pm_interface = {
.name = "exynos4_pm",
.subsys = &exynos4_subsys,
.subsys = &exynos_subsys,
.add_dev = exynos4_pm_add,
};

Expand Down
2 changes: 1 addition & 1 deletion arch/arm/plat-samsung/include/plat/cpu.h
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ extern struct bus_type s3c2443_subsys;
extern struct bus_type s3c6410_subsys;
extern struct bus_type s5p64x0_subsys;
extern struct bus_type s5pv210_subsys;
extern struct bus_type exynos4_subsys;
extern struct bus_type exynos_subsys;

extern void (*s5pc1xx_idle)(void);

Expand Down

0 comments on commit 9ee6af9

Please sign in to comment.