Skip to content

Commit

Permalink
gpio: adp5588-gpio: gpio_start must be signed
Browse files Browse the repository at this point in the history
Common code interprets this as a signed value (a negative value is used to
request dynamic ID allocation), so make sure the platform data has proper
types to support that.

Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Michael Hennerich authored and Linus Torvalds committed Oct 28, 2010
1 parent 459773a commit 9ef8c8c
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions include/linux/i2c/adp5588.h
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,9 @@ struct adp5588_kpad_platform_data {
};

struct adp5588_gpio_platform_data {
unsigned gpio_start; /* GPIO Chip base # */
unsigned irq_base; /* interrupt base # */
unsigned pullup_dis_mask; /* Pull-Up Disable Mask */
int gpio_start; /* GPIO Chip base # */
unsigned irq_base; /* interrupt base # */
unsigned pullup_dis_mask; /* Pull-Up Disable Mask */
int (*setup)(struct i2c_client *client,
int gpio, unsigned ngpio,
void *context);
Expand Down

0 comments on commit 9ef8c8c

Please sign in to comment.