Skip to content

Commit

Permalink
irq: hide debug macros so they don't collide with others.
Browse files Browse the repository at this point in the history
The file kernel/irq/debug.h temporarily defines P, PS, PD
and then undefines them.  However these names aren't really
"internal" enough, and collide with other more legit users
such as the ones in the xtensa arch, causing:

In file included from kernel/irq/internals.h:58:0,
                 from kernel/irq/irqdesc.c:18:
kernel/irq/debug.h:8:0: warning: "PS" redefined [enabled by default]
arch/xtensa/include/asm/regs.h:59:0: note: this is the location of the previous definition

Add a handful of underscores to do a better job of hiding these
temporary macros.

Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
  • Loading branch information
Paul Gortmaker committed Apr 23, 2012
1 parent bfae8ee commit 9f3045e
Showing 1 changed file with 19 additions and 19 deletions.
38 changes: 19 additions & 19 deletions kernel/irq/debug.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@

#include <linux/kallsyms.h>

#define P(f) if (desc->status_use_accessors & f) printk("%14s set\n", #f)
#define PS(f) if (desc->istate & f) printk("%14s set\n", #f)
#define ___P(f) if (desc->status_use_accessors & f) printk("%14s set\n", #f)
#define ___PS(f) if (desc->istate & f) printk("%14s set\n", #f)
/* FIXME */
#define PD(f) do { } while (0)
#define ___PD(f) do { } while (0)

static inline void print_irq_desc(unsigned int irq, struct irq_desc *desc)
{
Expand All @@ -23,23 +23,23 @@ static inline void print_irq_desc(unsigned int irq, struct irq_desc *desc)
print_symbol("%s\n", (unsigned long)desc->action->handler);
}

P(IRQ_LEVEL);
P(IRQ_PER_CPU);
P(IRQ_NOPROBE);
P(IRQ_NOREQUEST);
P(IRQ_NOTHREAD);
P(IRQ_NOAUTOEN);
___P(IRQ_LEVEL);
___P(IRQ_PER_CPU);
___P(IRQ_NOPROBE);
___P(IRQ_NOREQUEST);
___P(IRQ_NOTHREAD);
___P(IRQ_NOAUTOEN);

PS(IRQS_AUTODETECT);
PS(IRQS_REPLAY);
PS(IRQS_WAITING);
PS(IRQS_PENDING);
___PS(IRQS_AUTODETECT);
___PS(IRQS_REPLAY);
___PS(IRQS_WAITING);
___PS(IRQS_PENDING);

PD(IRQS_INPROGRESS);
PD(IRQS_DISABLED);
PD(IRQS_MASKED);
___PD(IRQS_INPROGRESS);
___PD(IRQS_DISABLED);
___PD(IRQS_MASKED);
}

#undef P
#undef PS
#undef PD
#undef ___P
#undef ___PS
#undef ___PD

0 comments on commit 9f3045e

Please sign in to comment.